* [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field
@ 2013-04-23 14:41 John Blackwood
2013-04-23 15:19 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: John Blackwood @ 2013-04-23 14:41 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: cpufreq, linux-pm
In the cpufreq conservative module, the cpu field in the cpu_dbs_info_s
structure was not being initialized, and thus all cpus were scheduling
their do_dbs_timer() delayed work processing on cpu 0.
Signed-off-by: John Blackwood <john.blackwood@ccur.com>
Index: b/drivers/cpufreq/cpufreq_conservative.c
===================================================================
--- a/drivers/cpufreq/cpufreq_conservative.c
+++ b/drivers/cpufreq/cpufreq_conservative.c
@@ -506,6 +506,7 @@ static int cpufreq_governor_dbs(struct c
}
this_dbs_info->down_skip = 0;
this_dbs_info->requested_freq = policy->cur;
+ this_dbs_info->cpu = cpu;
mutex_init(&this_dbs_info->timer_mutex);
dbs_enable++;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field
2013-04-23 14:41 [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field John Blackwood
@ 2013-04-23 15:19 ` Viresh Kumar
2013-04-23 15:27 ` John Blackwood
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2013-04-23 15:19 UTC (permalink / raw)
To: John Blackwood; +Cc: Rafael J. Wysocki, cpufreq, linux-pm
On Tue, Apr 23, 2013 at 8:11 PM, John Blackwood <john.blackwood@ccur.com> wrote:
> In the cpufreq conservative module, the cpu field in the cpu_dbs_info_s
> structure was not being initialized, and thus all cpus were scheduling
> their do_dbs_timer() delayed work processing on cpu 0.
>
> Signed-off-by: John Blackwood <john.blackwood@ccur.com>
> Index: b/drivers/cpufreq/cpufreq_conservative.c
> ===================================================================
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -506,6 +506,7 @@ static int cpufreq_governor_dbs(struct c
> }
> this_dbs_info->down_skip = 0;
> this_dbs_info->requested_freq = policy->cur;
> + this_dbs_info->cpu = cpu;
>
> mutex_init(&this_dbs_info->timer_mutex);
> dbs_enable++;
What have you rebased this on? I don't think its the latest code and is probably
a bit old.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field
2013-04-23 15:19 ` Viresh Kumar
@ 2013-04-23 15:27 ` John Blackwood
0 siblings, 0 replies; 3+ messages in thread
From: John Blackwood @ 2013-04-23 15:27 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org
On 04/23/2013 10:19 AM, Viresh Kumar wrote:
> On Tue, Apr 23, 2013 at 8:11 PM, John Blackwood <john.blackwood@ccur.com> wrote:
>> In the cpufreq conservative module, the cpu field in the cpu_dbs_info_s
>> structure was not being initialized, and thus all cpus were scheduling
>> their do_dbs_timer() delayed work processing on cpu 0.
>>
>> Signed-off-by: John Blackwood <john.blackwood@ccur.com>
>> Index: b/drivers/cpufreq/cpufreq_conservative.c
>> ===================================================================
>> --- a/drivers/cpufreq/cpufreq_conservative.c
>> +++ b/drivers/cpufreq/cpufreq_conservative.c
>> @@ -506,6 +506,7 @@ static int cpufreq_governor_dbs(struct c
>> }
>> this_dbs_info->down_skip = 0;
>> this_dbs_info->requested_freq = policy->cur;
>> + this_dbs_info->cpu = cpu;
>>
>> mutex_init(&this_dbs_info->timer_mutex);
>> dbs_enable++;
>
> What have you rebased this on? I don't think its the latest code and is probably
> a bit old.
>
Hi Viresh,
Yes, you are right.
This has been fixed in a different way in the newer kernel source.
My apologies.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-23 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-23 14:41 [PATCH] cpufreq_conservative: initialize the cpu_dbs_info_s cpu field John Blackwood
2013-04-23 15:19 ` Viresh Kumar
2013-04-23 15:27 ` John Blackwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox