From: Stephen Warren <swarren@wwwdotorg.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, arvind.chauhan@arm.com,
arnd@arndb.de, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 10/11] cpufreq: tegra: select CPU_FREQ_TABLE for ARCH_TEGRA
Date: Thu, 13 Jun 2013 09:43:55 -0600 [thread overview]
Message-ID: <51B9E8BB.9020104@wwwdotorg.org> (raw)
In-Reply-To: <CAKohponC5pKABTi=t64ZXrHxi-Y6cbvAXtjY=_aMkka4s-MCiQ@mail.gmail.com>
On 06/12/2013 10:24 PM, Viresh Kumar wrote:
> On 12 June 2013 21:20, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 06/12/2013 02:15 AM, Viresh Kumar wrote:
>>> ARCH_TEGRA selects ARCH_HAS_CPUFREQ, so CPUFREQ will be enabled for all variants
>>> of TEGRA. CPUFreq driver for tegra is enabled if ARCH_TEGRA is selected. Driver
>>> uses APIs from freq_table.c and so we must select CPU_FREQ_TABLE for ARCH_TEGRA.
>>>
>>> This also removes select CPU_FREQ_TABLE from individual tegra variants.
>>
>> I guess the real issue here is that drivers/cpufreq/tegra-cpufreq.c gets
>> built based on ARCH_TEGRA, which doesn't depend on nor select CPU_FREQ
>> itself, so:
>>
>> select CPU_FREQ_TABLE if CPU_FREQ
>>
>> ... isn't guaranteed to fire.
>>
>> The correct solution seems to be:
>>
>> * Add CONFIG_ARM_TEGRA_CPUFREQ to drivers/cpufreq/Kconfig.arm.
>> * Make that Kconfig option selct CPU_FREQ_TABLE.
>> * Make that Kconfig option be def_bool ARCH_TEGRA.
>> * Modify drivers/cpufreq/Makefile to build tegra-cpufreq.c based on that.
>> * Remove all the cpufreq-related stuff from arch/arm/mach-tegra/Kconfig.
>>
>> That way, tegra-cpufreq.c can't be built if !CPU_FREQ, and Tegra's
>> cpufreq works the same way as all the other cpufreq drivers.
>
> Hmmm. check this out (attached too for you to test):
This certainly generates the correct .config when I "make
tegra_defconfig" after applying it, and a build after disabling CPU_FREQ
links OK, so,
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
(I assume this patch would go through the cpufreq tree?)
next prev parent reply other threads:[~2013-06-13 15:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 8:15 [PATCH 00/11] CPUFreq Kconfig fixes Viresh Kumar
2013-06-12 8:15 ` [PATCH 01/11] cpufreq: blackfin: enable driver for CONFIG_BFIN_CPU_FREQ Viresh Kumar
2013-06-17 4:39 ` [uclinux-dist-devel] " Mike Frysinger
2013-06-12 8:15 ` [PATCH 02/11] cpufreq: cris: select CPU_FREQ_TABLE Viresh Kumar
2013-06-12 8:15 ` [PATCH 03/11] cpufreq: davinci: " Viresh Kumar
2013-06-12 8:15 ` [PATCH 04/11] cpufreq: exynos: " Viresh Kumar
2013-06-12 8:15 ` [PATCH 05/11] cpufreq: highbank: remove " Viresh Kumar
2013-06-12 17:04 ` Mark Langsdorf
2013-06-12 8:15 ` [PATCH 06/11] cpufreq: imx: " Viresh Kumar
2013-06-12 11:38 ` Shawn Guo
2013-06-12 8:15 ` [PATCH 07/11] cpufreq: powerpc: CBE_RAS: " Viresh Kumar
2013-06-12 8:15 ` [PATCH 08/11] cpufreq: pxa: " Viresh Kumar
2013-06-12 8:15 ` [PATCH 09/11] cpufreq: S3C2416/S3C64XX: " Viresh Kumar
2013-06-12 9:11 ` Heiko Stübner
2013-06-12 8:15 ` [PATCH 10/11] cpufreq: tegra: select CPU_FREQ_TABLE for ARCH_TEGRA Viresh Kumar
2013-06-12 15:50 ` Stephen Warren
2013-06-13 4:24 ` Viresh Kumar
2013-06-13 15:43 ` Stephen Warren [this message]
2013-06-13 15:46 ` Viresh Kumar
2013-06-12 8:15 ` [PATCH 11/11] cpufreq: X86_AMD_FREQ_SENSITIVITY: select CPU_FREQ_TABLE Viresh Kumar
2013-06-12 14:23 ` Jacob Shin
2013-06-12 12:46 ` [PATCH 00/11] CPUFreq Kconfig fixes Arnd Bergmann
2013-06-12 14:28 ` Viresh Kumar
2013-06-12 14:49 ` Arnd Bergmann
2013-06-12 22:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9E8BB.9020104@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arnd@arndb.de \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox