From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: cpufreq <cpufreq@vger.kernel.org>
Cc: dirk.brandewie@gmail.com, "Rafael J. Wysocki" <rjw@sisk.pl>,
srivatsa.bhat@linux.vnet.ibm.com, durgadoss.r@intel.com,
"Jarzmik, Robert" <robert.jarzmik@intel.com>,
tianyu.lan@intel.com
Subject: [REGRESSION] Commit a66b2e50 "Preserve sysfs files across suspend/resume" causes a regression in intel_pstate
Date: Wed, 10 Jul 2013 09:15:12 -0700 [thread overview]
Message-ID: <51DD8890.8040008@gmail.com> (raw)
Hi All,
Tianyu debugged into https://bugzilla.kernel.org/show_bug.cgi?id=59781 and found
that commit a66b2e50 is causing the regression.
Tianyu has proposed a fix (patch attached to bugzilla) but having scaling
drivers receive hotplug notifications through two paths seems weird.
Looking at the core code and some of the other scaling drivers
I don't see an obvious fix. Maybe adding optional suspend/resume callbacks
to the scaling driver interface?
All the scaling drivers that need to do stateful work in the init/exit
callbacks are being affected by this change so I think there are other
subtle side-effects out there that haven't been noticed yet.
I am not sure how we should proceed here?
Thoughts?
--Dirk
next reply other threads:[~2013-07-10 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 16:15 Dirk Brandewie [this message]
2013-07-10 22:04 ` [REGRESSION] Commit a66b2e50 "Preserve sysfs files across suspend/resume" causes a regression in intel_pstate Rafael J. Wysocki
2013-07-10 22:25 ` Srivatsa S. Bhat
2013-07-10 22:18 ` Srivatsa S. Bhat
2013-07-11 7:09 ` Viresh Kumar
2013-07-11 7:22 ` Srivatsa S. Bhat
2013-07-11 7:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD8890.8040008@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=durgadoss.r@intel.com \
--cc=rjw@sisk.pl \
--cc=robert.jarzmik@intel.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).