From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/3 v6] cpufreq: Add debugfs directory for cpufreq Date: Wed, 24 Jul 2013 18:14:31 +0900 Message-ID: <51EF9AF7.60007@samsung.com> References: <1374146275-5758-1-git-send-email-cw00.choi@samsung.com> <1374146275-5758-2-git-send-email-cw00.choi@samsung.com> <51EF2D06.7000704@samsung.com> <51EF8590.7030405@samsung.com> <51EF945E.3080802@samsung.com> <51EF98DD.4010607@samsung.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cpufreq@vger.kernel.org, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, Lists linaro-kernel On 07/24/2013 06:09 PM, Viresh Kumar wrote: > On 24 July 2013 14:35, Chanwoo Choi wrote: >> And, I add additional step on below: >> >>> - Remove symlink for new policy->cpu, i..e cpu1 in your example >>> - rename debugfs entry to give it to cpu1 instead of cpu0. >> - Store renamed cpu0 pointer to cpu1 pointer >> - Create new link for CPU[2-3] to CPU1's debugfs directory >> because debugfs use string path to create symbolic link. >> It isn't automatically connected with new CPU1 debugfs directory. > > Honestly speaking I am not the best at debugfs core, but I still think > the link is connected to a struct debugfs node and not to any path.. > This node is connected to a path though. And so even after rename > things should stay stable without your new step... > > Just try and see if I am right or wrong.. Otherwise what you already > did is correct as you need to remove links for 2-3 as well.. > OK, I'll try it according to your suggestion. Thanks. Best Regards, Chanwoo Choi