Re: [PATCH 5/6] ARM: Tegra: start using cpufreq-cpu0 driver

Viresh Kumar
2013-08-08T02:48:36Z

On 8 August 2013 00:21, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 08/07/2013 11:59 AM, Viresh Kumar wrote:
>> On 7 August 2013 23:23, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> That link only describes why we shouldn't have a dedicated compatible
>>> value for cpufreq. I certainly agree with that. However, I think it's
>>> reasonable that whatever code binds to:
>>>
>>> compatible = "arm,cortex-a9";
>>>
>>> ... should instantiate any virtual devices that relate to the CPU.
>>
>> But how would we know here if platform really wants us to probe
>> cpufreq-cpu0 driver? On multiplatform kernel there can be multiple
>> cpufreq drivers available and there has to be some sort of code
>> in DT or platform code that reflects which driver we want to use.
>
> Presumably the code would look at the top-level DT node's compatible
> value (e.g. "nvidia,tegra20").

So you are actually asking us to get a compatibility list inside
cpufreq-cpu0 driver which will list all the platforms for which this driver
would work?

Honestly speaking I wasn't in favor of getting a platform-device
registered for cpufreq-cpu0 earlier and had few discussion on the
thread I passed to you.

The problem with the new solution you just proposed is, for every
new platform that comes in we need to update this file.. And that's
it probably..

Don't know how others would see it...
@Rafael/Rob/Shawn: Any suggestions here?