Re: [PATCH 5/6] ARM: Tegra: start using cpufreq-cpu0 driver

Stephen Warren
2013-08-07T17:46:18Z

On 08/07/2013 08:46 AM, Viresh Kumar wrote:
> cpufreq-cpu0 driver can be probed over DT only if a corresponding device node is
> created for the SoC which wants to use it. Lets create a platform device for
> cpufreq-cpu0 driver for Tegra.
>
> Also it removes the Kconfig entry responsible to compiling tegra-cpufreq driver
> and hence there will not be any conflicts between two cpufreq drivers.

> diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c

> static void __init tegra_dt_init(void)
> {
> + struct platform_device_info devinfo = { .name = "cpufreq-cpu0", };

static? const?

> struct soc_device_attribute *soc_dev_attr;
> struct soc_device *soc_dev;
> struct device *parent = NULL;
>
> tegra_clocks_apply_init_table();
> + platform_device_register_full(&devinfo);

This seems awfully like going back to board files. Shouldn't something
that binds to the CPU nodes register the cpufreq device automatically,
based on the CPU's compatible value?