From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish() Date: Thu, 12 Sep 2013 12:08:04 -0600 Message-ID: <52320304.306@wwwdotorg.org> References: <8f777cc6b41b2fed4bf71ce2adc36800353d5738.1378963070.git.viresh.kumar@linaro.org> <523161D1.9040005@linux.vnet.ibm.com> <52316A40.4050600@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: "Srivatsa S. Bhat" , "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List On 09/12/2013 03:21 AM, Viresh Kumar wrote: > On 12 September 2013 12:46, Srivatsa S. Bhat > wrote: >> That sounds good! Even the naming is much better, it conveys the intent >> clearly. > > Folded below change in my patch (attached): ... For the record, the patch which was attached to Viresh's email solves the hangs I was getting in next-20130912 during (the second?) CPU hotplug and resume. So, Tested-by: Stephen Warren Without this, I saw: > root@localhost:~# ./cpuonline.py > echo 0 > /sys/devices/system/cpu/cpu1/online > [ 24.049729] CPU1: shutdown > echo 1 > /sys/devices/system/cpu/cpu1/online > [ 26.090439] CPU1: Booted secondary processor > root@localhost:~# ./cpuonline.py > echo 0 > /sys/devices/system/cpu/cpu1/online > [ 29.003016] CPU1: shutdown > echo 1 > /sys/devices/system/cpu/cpu1/online > [ 31.032562] CPU1: Booted secondary processor [hung] > [ 240.300393] INFO: task ondemand:678 blocked for more than 120 seconds. > [ 240.312842] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > [ 240.326658] ondemand D c050f6cc 0 678 1 0x00000000 > [ 240.339062] [] (__schedule+0x330/0x6d0) from [] (schedule_preempt_disabled+0x24/0x34) > [ 240.354904] [] (schedule_preempt_disabled+0x24/0x34) from [] (__mutex_lock_slowpath+0x178/0x370) > [ 240.371767] [] (__mutex_lock_slowpath+0x178/0x370) from [] (mutex_lock+0xc/0x24) > [ 240.387363] [] (mutex_lock+0xc/0x24) from [] (get_online_cpus+0x2c/0x48) > [ 240.402273] [] (get_online_cpus+0x2c/0x48) from [] (store+0x18/0xbc) > [ 240.417688] [] (store+0x18/0xbc) from [] (sysfs_write_file+0x168/0x198) > [ 240.432687] [] (sysfs_write_file+0x168/0x198) from [] (vfs_write+0xb0/0x188) > [ 240.448185] [] (vfs_write+0xb0/0x188) from [] (SyS_write+0x3c/0x70) > [ 240.462964] [] (SyS_write+0x3c/0x70) from [] (ret_fast_syscall+0x0/0x30) > [ 240.478239] INFO: task sh:827 blocked for more than 120 seconds. > [ 240.491027] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > [ 240.505795] sh D c050f6cc 0 827 825 0x00000001 > [ 240.519169] [] (__schedule+0x330/0x6d0) from [] (__down_write_nested+0x78/0xcc) > [ 240.535666] [] (__down_write_nested+0x78/0xcc) from [] (lock_policy_rwsem_write+0x34/0x48) > [ 240.552950] [] (lock_policy_rwsem_write+0x34/0x48) from [] (cpufreq_update_policy+0x20/0xec) > [ 240.570631] [] (cpufreq_update_policy+0x20/0xec) from [] (cpufreq_cpu_callback+0x78/0x8c) > [ 240.588051] [] (cpufreq_cpu_callback+0x78/0x8c) from [] (notifier_call_chain+0x44/0x84) > [ 240.605401] [] (notifier_call_chain+0x44/0x84) from [] (__cpu_notify+0x28/0x44) > [ 240.622085] [] (__cpu_notify+0x28/0x44) from [] (_cpu_up+0x100/0x154) > [ 240.638006] [] (_cpu_up+0x100/0x154) from [] (cpu_up+0x5c/0x84) > [ 240.653405] [] (cpu_up+0x5c/0x84) from [] (device_online+0x64/0x88) > [ 240.669263] [] (device_online+0x64/0x88) from [] (store_online+0x5c/0x64) > [ 240.685683] [] (store_online+0x5c/0x64) from [] (dev_attr_store+0x18/0x24) > [ 240.702337] [] (dev_attr_store+0x18/0x24) from [] (sysfs_write_file+0x168/0x198) > [ 240.719520] [] (sysfs_write_file+0x168/0x198) from [] (vfs_write+0xb0/0x188) > [ 240.736614] [] (vfs_write+0xb0/0x188) from [] (SyS_write+0x3c/0x70) > [ 240.752799] [] (SyS_write+0x3c/0x70) from [] (ret_fast_syscall+0x0/0x30)