From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 5/5] cpufreq: use correct values of cpus in __cpufreq_remove_dev_finish() Date: Tue, 17 Sep 2013 09:20:35 -0600 Message-ID: <52387343.7040007@wwwdotorg.org> References: <8f777cc6b41b2fed4bf71ce2adc36800353d5738.1378963070.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8f777cc6b41b2fed4bf71ce2adc36800353d5738.1378963070.git.viresh.kumar@linaro.org> Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: rjw@sisk.pl, srivatsa.bhat@linux.vnet.ibm.com, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 09/11/2013 11:25 PM, Viresh Kumar wrote: > This broke after a recent change "cedb70a cpufreq: Split __cpufreq_remove_dev() > into two parts" from Srivatsa.. > > Consider a scenario where we have two CPUs in a policy (0 & 1) and we are > removing cpu 1. On the call to __cpufreq_remove_dev_prepare() we have cleared 1 > from policy->cpus and now on a call to __cpufreq_remove_dev_finish() we read > cpumask_weight of policy->cpus, which will come as 1 and this code will behave > as if we are removing the last cpu from policy :) > > Fix it by clearing cpu mask in __cpufreq_remove_dev_finish() instead of > __cpufreq_remove_dev_prepare(). I see this patch isn't in linux-next yet, nor did it make 3.12-rc1. I assume it'll make 3.12-rc2? It solves various CPU hotplug and suspend/resume issues for me.