From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk'
Date: Tue, 08 Apr 2014 09:01:02 +0800
Message-ID: <53434A4E.2050407@gmail.com>
References: <53429445.5000005@gmail.com> <CAKohpok189SxuJoGNvgshwEaUozMDM9mzA8wse5COkN8MBUaPg@mail.gmail.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <stable-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=flgKmSe0O+ssWx1IatbKHHfrk5ysUNR9KFWrdRGDxZY=;
        b=Uar3U+wu1hlCOoRPOj/vnpWZIce2b1mnhwh+hfwY691OievasUebc0YbtDq1q4OVlj
         k7SWCqbe5qFrSM/8LA6HNre24yjCoxuu4JVSsUVkXPSBn6LocNrRcwzNZ1ebYpac07Ix
         z5tl2V7muyEI/hTgtXgKs4qKPW6WJCUhJAAG/MbRUdAruQ/+o2sMYk8pcw/U22au08KY
         L4CHSbF33OmeOfh7f8poj2m/w/fADZho2bjupsul+ObirNA/qbMzmwmjQ8I5EHE9xCOm
         EunZatXfAQN0tZi/0CRuSb2iTJd/E4jXp34ZNlgPtgJMI6hm3eRZe7yRL+LPa21dY4pd
         h2BA==
In-Reply-To: <CAKohpok189SxuJoGNvgshwEaUozMDM9mzA8wse5COkN8MBUaPg@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
List-ID: <cpufreq.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, stable@vger.kernel.org

On 04/07/2014 08:08 PM, Viresh Kumar wrote:
> On 7 April 2014 17:34, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> Need use 'clk' instead of 'mclk', which is the original removed local
>> variable.
>>
>> The related original commit:
>>
>>   "652ed95 cpufreq: introduce cpufreq_generic_get() routine"
>>
>> The related error with allmodconfig for unicore32:
>>
>>     CC      drivers/cpufreq/unicore2-cpufreq.o
>>   drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target':
>>   drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct cpufreq_policy' has no member named 'mclk'
>>   make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1
>>   make[1]: *** [drivers/cpufreq] Error 2
>>   make: *** [drivers] Error 2
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  drivers/cpufreq/unicore2-cpufreq.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Stupid mistake.
> 

It is very easy to lead other members to make mistakes, or let ourself
make mistakes.

> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> @stable: please apply this for v3.14, as it broke in that cycle..
> 

Thank you.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed