* [PATCH] cpufreq, powernv: Fix build failure on UP [not found] <20140415141111.GA28352@windriver.com> @ 2014-04-16 5:48 ` Srivatsa S. Bhat 2014-04-16 5:55 ` Viresh Kumar 0 siblings, 1 reply; 3+ messages in thread From: Srivatsa S. Bhat @ 2014-04-16 5:48 UTC (permalink / raw) To: Paul Gortmaker, Rafael J. Wysocki Cc: ego, svaidy, preeti, linux-next, rafael.j.wysocki, Viresh Kumar, cpufreq, Linux PM mailing list, linux-kernel@vger.kernel.org On 04/15/2014 07:41 PM, Paul Gortmaker wrote: > Hi all, > > This new driver is causing build fails on linux-next for non-SMP. > > http://kisskb.ellerman.id.au/kisskb/buildresult/10911507/ > > I didn't bisect since there are only two commits in total. :) > > Looks like some header foo where <linux/smp.h> is not getting <asm/smp.h> > Hi Paul, Thanks a lot for reporting the build failure. Please find the fix below. Regards, Srivatsa S. Bhat --------------------------------------------------------------------------- From: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Subject: [PATCH] cpufreq, powernv: Fix build failure on UP Paul Gortmaker reported the following build failure of the powernv cpufreq driver on UP configs: drivers/cpufreq/powernv-cpufreq.c:241:2: error: implicit declaration of function 'cpu_sibling_mask' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[3]: *** [drivers/cpufreq/powernv-cpufreq.o] Error 1 make[2]: *** [drivers/cpufreq] Error 2 make[1]: *** [drivers] Error 2 make: *** [sub-make] Error 2 The trouble here is that cpu_sibling_mask is defined only in <asm/smp.h>, and <linux/smp.h> includes <asm/smp.h> only in SMP builds. So fix this build failure by explicitly including <asm/smp.h> in the driver, so that we get the definition of cpu_sibling_mask even in UP configurations. Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- drivers/cpufreq/powernv-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 9edccc6..ed1c7e5 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -29,6 +29,7 @@ #include <asm/cputhreads.h> #include <asm/reg.h> +#include <asm/smp.h> #define POWERNV_MAX_PSTATES 256 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq, powernv: Fix build failure on UP 2014-04-16 5:48 ` [PATCH] cpufreq, powernv: Fix build failure on UP Srivatsa S. Bhat @ 2014-04-16 5:55 ` Viresh Kumar 2014-04-16 6:01 ` Srivatsa S. Bhat 0 siblings, 1 reply; 3+ messages in thread From: Viresh Kumar @ 2014-04-16 5:55 UTC (permalink / raw) To: Srivatsa S. Bhat Cc: Paul Gortmaker, Rafael J. Wysocki, ego@linux.vnet.ibm.com, Vaidyanathan Srinivasan, Preeti U Murthy, linux-next list, Rafael J. Wysocki, cpufreq, Linux PM mailing list, linux-kernel@vger.kernel.org On 16 April 2014 11:18, Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> wrote: > From: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > Subject: [PATCH] cpufreq, powernv: Fix build failure on UP > > Paul Gortmaker reported the following build failure of the powernv cpufreq > driver on UP configs: > > drivers/cpufreq/powernv-cpufreq.c:241:2: error: implicit declaration of > function 'cpu_sibling_mask' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > make[3]: *** [drivers/cpufreq/powernv-cpufreq.o] Error 1 > make[2]: *** [drivers/cpufreq] Error 2 > make[1]: *** [drivers] Error 2 > make: *** [sub-make] Error 2 > > The trouble here is that cpu_sibling_mask is defined only in <asm/smp.h>, and > <linux/smp.h> includes <asm/smp.h> only in SMP builds. > > So fix this build failure by explicitly including <asm/smp.h> in the driver, > so that we get the definition of cpu_sibling_mask even in UP configurations. > > Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com> > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > --- > > drivers/cpufreq/powernv-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 9edccc6..ed1c7e5 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -29,6 +29,7 @@ > > #include <asm/cputhreads.h> > #include <asm/reg.h> Probably a comment here ?, so that people don't try to remove it in future. /* Required for cpu_sibling_mask() in UP configurations */ > +#include <asm/smp.h> > > #define POWERNV_MAX_PSTATES 256 Acked-by: Viresh Kumar <viresh.kumar@linaro.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq, powernv: Fix build failure on UP 2014-04-16 5:55 ` Viresh Kumar @ 2014-04-16 6:01 ` Srivatsa S. Bhat 0 siblings, 0 replies; 3+ messages in thread From: Srivatsa S. Bhat @ 2014-04-16 6:01 UTC (permalink / raw) To: Viresh Kumar Cc: Paul Gortmaker, Rafael J. Wysocki, ego@linux.vnet.ibm.com, Vaidyanathan Srinivasan, Preeti U Murthy, linux-next list, Rafael J. Wysocki, cpufreq, Linux PM mailing list, linux-kernel@vger.kernel.org On 04/16/2014 11:25 AM, Viresh Kumar wrote: > On 16 April 2014 11:18, Srivatsa S. Bhat > <srivatsa.bhat@linux.vnet.ibm.com> wrote: >> From: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> Subject: [PATCH] cpufreq, powernv: Fix build failure on UP >> >> Paul Gortmaker reported the following build failure of the powernv cpufreq >> driver on UP configs: >> >> drivers/cpufreq/powernv-cpufreq.c:241:2: error: implicit declaration of >> function 'cpu_sibling_mask' [-Werror=implicit-function-declaration] >> cc1: some warnings being treated as errors >> make[3]: *** [drivers/cpufreq/powernv-cpufreq.o] Error 1 >> make[2]: *** [drivers/cpufreq] Error 2 >> make[1]: *** [drivers] Error 2 >> make: *** [sub-make] Error 2 >> >> The trouble here is that cpu_sibling_mask is defined only in <asm/smp.h>, and >> <linux/smp.h> includes <asm/smp.h> only in SMP builds. >> >> So fix this build failure by explicitly including <asm/smp.h> in the driver, >> so that we get the definition of cpu_sibling_mask even in UP configurations. >> >> Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> --- >> >> drivers/cpufreq/powernv-cpufreq.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c >> index 9edccc6..ed1c7e5 100644 >> --- a/drivers/cpufreq/powernv-cpufreq.c >> +++ b/drivers/cpufreq/powernv-cpufreq.c >> @@ -29,6 +29,7 @@ >> >> #include <asm/cputhreads.h> >> #include <asm/reg.h> > > Probably a comment here ?, so that people don't try to remove it in future. > Sure, that sounds like a good idea. > /* Required for cpu_sibling_mask() in UP configurations */ > >> +#include <asm/smp.h> >> >> #define POWERNV_MAX_PSTATES 256 > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Thank you! Regards, Srivatsa S. Bhat ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-16 6:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140415141111.GA28352@windriver.com>
2014-04-16 5:48 ` [PATCH] cpufreq, powernv: Fix build failure on UP Srivatsa S. Bhat
2014-04-16 5:55 ` Viresh Kumar
2014-04-16 6:01 ` Srivatsa S. Bhat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).