From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Meelis Roos <mroos@linux.ee>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end
Date: Fri, 25 Apr 2014 14:09:47 +0530 [thread overview]
Message-ID: <535A1F53.5040806@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKohpo=0wppEthZzoRGTqurtt=135NWeVTKJ2y=mwy82+O7-zQ@mail.gmail.com>
On 04/25/2014 02:07 PM, Viresh Kumar wrote:
> On 25 April 2014 13:48, Srivatsa S. Bhat
> <srivatsa.bhat@linux.vnet.ibm.com> wrote:
>
>> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
>
>> @@ -269,8 +269,6 @@ static void longhaul_setstate(struct cpufreq_policy *policy,
>
> This routine has this code as well:
>
> mult = mults[mults_index & 0x1f];
> if (mult == -1)
> return;
> speed = calc_speed(mult);
> if ((speed > highest_speed) || (speed < lowest_speed))
> return;
>
> And so it might return without changing frequency and that's why I
> left this driver earlier for this change.. So, please return -EINVAL
> from here..
>
Ok, I'll address this in the next version. Thanks for pointing
this out!
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2014-04-25 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 8:17 [PATCH 0/3] Cpufreq frequency serialization fixes Srivatsa S. Bhat
2014-04-25 8:18 ` [PATCH 1/3] cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end Srivatsa S. Bhat
2014-04-25 8:37 ` Viresh Kumar
2014-04-25 8:39 ` Srivatsa S. Bhat [this message]
2014-04-25 8:18 ` [PATCH 2/3] cpufreq, powernow-k6: " Srivatsa S. Bhat
2014-04-25 8:28 ` Viresh Kumar
2014-04-25 8:42 ` Srivatsa S. Bhat
2014-04-25 8:18 ` [PATCH 3/3] cpufreq, powernow-k7: " Srivatsa S. Bhat
2014-04-25 8:24 ` Viresh Kumar
2014-04-25 17:29 ` [PATCH 0/3] Cpufreq frequency serialization fixes Meelis Roos
2014-04-28 18:47 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A1F53.5040806@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).