* [PATCH] cpufreq: powernv: make local function static
@ 2014-05-11 7:51 Brian Norris
2014-05-11 18:32 ` Srivatsa S. Bhat
2014-05-12 4:24 ` Viresh Kumar
0 siblings, 2 replies; 5+ messages in thread
From: Brian Norris @ 2014-05-11 7:51 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Brian Norris, Viresh Kumar, cpufreq, linux-pm
powernv_cpufreq_get() is only referenced in this file.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: cpufreq@vger.kernel.org
Cc: linux-pm@vger.kernel.org
---
drivers/cpufreq/powernv-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index af4968813e76..bb1d08dc8cc8 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
* firmware for CPU 'cpu'. This value is reported through the sysfs
* file cpuinfo_cur_freq.
*/
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)
{
struct powernv_smp_call_data freq_data;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: powernv: make local function static
2014-05-11 7:51 [PATCH] cpufreq: powernv: make local function static Brian Norris
@ 2014-05-11 18:32 ` Srivatsa S. Bhat
2014-05-12 5:54 ` Gautham R Shenoy
2014-05-12 4:24 ` Viresh Kumar
1 sibling, 1 reply; 5+ messages in thread
From: Srivatsa S. Bhat @ 2014-05-11 18:32 UTC (permalink / raw)
To: Brian Norris
Cc: Rafael J. Wysocki, Viresh Kumar, cpufreq, linux-pm,
Vaidyanathan Srinivasan, ego@linux.vnet.ibm.com, Preeti U Murthy
On 05/11/2014 01:21 PM, Brian Norris wrote:
> powernv_cpufreq_get() is only referenced in this file.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: cpufreq@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> ---
> drivers/cpufreq/powernv-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index af4968813e76..bb1d08dc8cc8 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
> * firmware for CPU 'cpu'. This value is reported through the sysfs
> * file cpuinfo_cur_freq.
> */
> -unsigned int powernv_cpufreq_get(unsigned int cpu)
> +static unsigned int powernv_cpufreq_get(unsigned int cpu)
> {
> struct powernv_smp_call_data freq_data;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: powernv: make local function static
2014-05-11 18:32 ` Srivatsa S. Bhat
@ 2014-05-12 5:54 ` Gautham R Shenoy
2014-05-19 23:21 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Gautham R Shenoy @ 2014-05-12 5:54 UTC (permalink / raw)
To: Srivatsa S. Bhat
Cc: Brian Norris, Rafael J. Wysocki, Viresh Kumar, cpufreq, linux-pm,
Vaidyanathan Srinivasan, ego@linux.vnet.ibm.com, Preeti U Murthy
On Mon, May 12, 2014 at 12:02:52AM +0530, Srivatsa S. Bhat wrote:
> On 05/11/2014 01:21 PM, Brian Norris wrote:
> > powernv_cpufreq_get() is only referenced in this file.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Cc: cpufreq@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
>
> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for this fix Brian.
Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
--
Thanks and Regards
gautham.
>
> Regards,
> Srivatsa S. Bhat
>
> > ---
> > drivers/cpufreq/powernv-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> > index af4968813e76..bb1d08dc8cc8 100644
> > --- a/drivers/cpufreq/powernv-cpufreq.c
> > +++ b/drivers/cpufreq/powernv-cpufreq.c
> > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
> > * firmware for CPU 'cpu'. This value is reported through the sysfs
> > * file cpuinfo_cur_freq.
> > */
> > -unsigned int powernv_cpufreq_get(unsigned int cpu)
> > +static unsigned int powernv_cpufreq_get(unsigned int cpu)
> > {
> > struct powernv_smp_call_data freq_data;
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: powernv: make local function static
2014-05-12 5:54 ` Gautham R Shenoy
@ 2014-05-19 23:21 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-05-19 23:21 UTC (permalink / raw)
To: ego
Cc: Srivatsa S. Bhat, Brian Norris, Rafael J. Wysocki, Viresh Kumar,
cpufreq, linux-pm, Vaidyanathan Srinivasan, Preeti U Murthy
On Monday, May 12, 2014 11:24:06 AM Gautham R Shenoy wrote:
> On Mon, May 12, 2014 at 12:02:52AM +0530, Srivatsa S. Bhat wrote:
> > On 05/11/2014 01:21 PM, Brian Norris wrote:
> > > powernv_cpufreq_get() is only referenced in this file.
> > >
> > > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > Cc: cpufreq@vger.kernel.org
> > > Cc: linux-pm@vger.kernel.org
> >
> > Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
>
> Thanks for this fix Brian.
>
> Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Queued up for 3.16, thanks!
>
> --
> Thanks and Regards
> gautham.
>
> >
> > Regards,
> > Srivatsa S. Bhat
> >
> > > ---
> > > drivers/cpufreq/powernv-cpufreq.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> > > index af4968813e76..bb1d08dc8cc8 100644
> > > --- a/drivers/cpufreq/powernv-cpufreq.c
> > > +++ b/drivers/cpufreq/powernv-cpufreq.c
> > > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
> > > * firmware for CPU 'cpu'. This value is reported through the sysfs
> > > * file cpuinfo_cur_freq.
> > > */
> > > -unsigned int powernv_cpufreq_get(unsigned int cpu)
> > > +static unsigned int powernv_cpufreq_get(unsigned int cpu)
> > > {
> > > struct powernv_smp_call_data freq_data;
> > >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: powernv: make local function static
2014-05-11 7:51 [PATCH] cpufreq: powernv: make local function static Brian Norris
2014-05-11 18:32 ` Srivatsa S. Bhat
@ 2014-05-12 4:24 ` Viresh Kumar
1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2014-05-12 4:24 UTC (permalink / raw)
To: Brian Norris
Cc: Rafael J. Wysocki, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org
On 11 May 2014 13:21, Brian Norris <computersforpeace@gmail.com> wrote:
> powernv_cpufreq_get() is only referenced in this file.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: cpufreq@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/cpufreq/powernv-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index af4968813e76..bb1d08dc8cc8 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
> * firmware for CPU 'cpu'. This value is reported through the sysfs
> * file cpuinfo_cur_freq.
> */
> -unsigned int powernv_cpufreq_get(unsigned int cpu)
> +static unsigned int powernv_cpufreq_get(unsigned int cpu)
Please make this as static as well: cpufreq_freq_attr_cpuinfo_nominal_freq
and add my
Acked-by: Viresh Kumar <viresh.kumar@linaro.org> on V2.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-19 23:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-11 7:51 [PATCH] cpufreq: powernv: make local function static Brian Norris
2014-05-11 18:32 ` Srivatsa S. Bhat
2014-05-12 5:54 ` Gautham R Shenoy
2014-05-19 23:21 ` Rafael J. Wysocki
2014-05-12 4:24 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).