cpufreq.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Mike Turquette <mike.turquette@linaro.org>,
	Morten Rasmussen <morten.rasmussen@arm.com>,
	mingo@kernel.org, len.brown@intel.com, rjw@rjwysocki.net,
	"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-acpi@vger.kernel.org, cpufreq@vger.kernel.org,
	Patch Tracking <patches@linaro.org>,
	Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: Re: [RFC 0/3] Experimental patchset for CPPC
Date: Fri, 15 Aug 2014 08:47:54 -0700	[thread overview]
Message-ID: <53EE2BAA.1020603@linux.intel.com> (raw)
In-Reply-To: <CAJ5Y-eZiRyGroems7J2oH05ybbbivM-okm3gFz7Mkuu8ceeCDQ@mail.gmail.com>

On 8/15/2014 7:24 AM, Ashwin Chaugule wrote:
>>>
>>> we've found that so far that there are two reasonable options
>>> 1) Let the OS device (old style)
>>> 2) Let the hardware decide (new style)
>>>
>>> 2) is there in practice today in the turbo range (which is increasingly
>>> the whole thing)
>>> and the hardware can make decisions about power budgetting on a timescale
>>> the OS
>>> can never even dream of, so once you give control the the hardware (with
>>> CPPC or native)
>>> it's normally better to just get out of the way as OS.
>>>
>>
>
> Interesting. This sounds like X86 plans to use the Autonomous bits
> that got added to the CPPC spec. (v5.1)?

if and when x86/Intel implement that, we will certainly evaluate it to see
how it behaves... but based on todays use of the hw control of the actual
p-state... I would expect that evaluation to pass.


note that on todays multi-core x96 systems, in practice you operate mostly
in the turbo range (I am ignoring mostly-idle workloads since there the
p-state isn't nearly as relevant anyway); all it takes for one of the cores to request
a turbo-range state, and the whole chip operates in turbo mode.. and in turbo mode
the hardware already picks the frequency/voltage.

with the current (and more so, past) Linux behavior, even at moderate loads you end up
there; the more cores you have the more true that becomes.



> I agree that the platform can
> make decisions on a much finer timescale. But even in the
> non-Autonomous mode, by providing the bounds around a Desired Value,
> the OS can get out of the way knowing that the platform would deliver
> something in the range it requested. If the OS can provide bounds, it
> seems to me that the platform can make more optimum decisions, rather
> than trying to guess whats running (or not).

I highly question that the OS can provide intelligent bounds.

When are you going to request an upper bound that is lower than maximum?
(don't say thermals, there are other mechanisms for controlling thermals
that work much better than direct P state control). Are you still going to do that
even if sometimes lower frequencies end up costing more battery?
(race-to-halt and all that)


I can see cases where you bump the minimum for QoS reasons, but even there I would
dare to say that at best the OS will be doing wild-ass guesses.



  reply	other threads:[~2014-08-15 15:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 19:57 [RFC 0/3] Experimental patchset for CPPC Ashwin Chaugule
2014-08-14 19:57 ` [RFC 1/3] ACPI: Add support for Platform Communication Channel Ashwin Chaugule
2014-08-14 20:11   ` Ashwin Chaugule
2014-08-14 19:57 ` [RFC 2/3] CPPC: Add support for Collaborative Processor Performance Control Ashwin Chaugule
2014-08-14 20:12   ` Ashwin Chaugule
2014-08-14 19:57 ` [RFC 3/3] CPPC: Add ACPI accessors to CPC registers Ashwin Chaugule
2014-08-14 20:12   ` Ashwin Chaugule
2014-08-14 20:11 ` [RFC 0/3] Experimental patchset for CPPC Ashwin Chaugule
2014-08-14 20:51 ` Peter Zijlstra
2014-08-14 21:56   ` Ashwin Chaugule
2014-08-15  6:19     ` Peter Zijlstra
2014-08-15 13:08       ` Ashwin Chaugule
2014-08-15 13:42         ` Arjan van de Ven
2014-08-15 13:53           ` Arjan van de Ven
2014-08-15 14:24             ` Ashwin Chaugule
2014-08-15 15:47               ` Arjan van de Ven [this message]
2014-08-15 16:41                 ` Ashwin Chaugule
2014-08-15 22:11                   ` Len Brown
2014-08-18 15:04                     ` Ashwin Chaugule
2014-08-15 14:00           ` Peter Zijlstra
2014-08-15 14:07         ` Peter Zijlstra
2014-08-15 14:37           ` Ashwin Chaugule
2014-08-15 14:41             ` Peter Zijlstra
2014-08-18 14:54               ` Ashwin Chaugule
2014-08-15 22:22 ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE2BAA.1020603@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=ashwin.chaugule@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=dirk.brandewie@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.turquette@linaro.org \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=patches@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).