From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net
Cc: linaro-kernel@lists.linaro.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
nm@ti.com, swarren@wwwdotorg.org, kgene.kim@samsung.com,
jinchoi@broadcom.com, tianyu.lan@intel.com,
sebastian.capella@linaro.org, jhbird.choi@samsung.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V6 2/7] cpufreq: suspend governors from dpm_{suspend|resume}()
Date: Mon, 17 Feb 2014 14:55:08 +0530 [thread overview]
Message-ID: <5b79cd9aa706d988d242d80d73cfe67c0e6c5b3d.1392629003.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1392629003.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1392629003.git.viresh.kumar@linaro.org>
Previous patch added support for suspending governors, with callbacks being
called from dpm_{suspend|resume}_noirq(). The problem here is that most of the
devices (i.e. devices with ->suspend() callbacks) have already been suspended by
now and so if drivers want to change frequency before suspending, then it might
not be possible for many platforms (which depend on other peripherals like i2c,
regulators, etc).
So, we actually need to do this from dpm_{suspend|resume}() instead. This patch
does it.
Tested-by: Lan Tianyu <tianyu.lan@intel.com>
Tested-by: Nishanth Menon <nm@ti.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index da49882..0f82012 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -582,7 +582,6 @@ static void dpm_resume_noirq(pm_message_t state)
dpm_show_time(starttime, state, "noirq");
resume_device_irqs();
cpuidle_resume();
- cpufreq_resume();
}
/**
@@ -858,6 +857,8 @@ void dpm_resume(pm_message_t state)
mutex_unlock(&dpm_list_mtx);
async_synchronize_full();
dpm_show_time(starttime, state, NULL);
+
+ cpufreq_resume();
}
/**
@@ -1063,7 +1064,6 @@ static int dpm_suspend_noirq(pm_message_t state)
ktime_t starttime = ktime_get();
int error = 0;
- cpufreq_suspend();
cpuidle_pause();
suspend_device_irqs();
mutex_lock(&dpm_list_mtx);
@@ -1415,6 +1415,8 @@ int dpm_suspend(pm_message_t state)
might_sleep();
+ cpufreq_suspend();
+
mutex_lock(&dpm_list_mtx);
pm_transition = state;
async_error = 0;
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2014-02-17 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 9:25 [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 1/7] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2014-02-17 9:25 ` Viresh Kumar [this message]
2014-03-02 0:01 ` [PATCH V6 2/7] cpufreq: suspend governors from dpm_{suspend|resume}() Rafael J. Wysocki
2014-02-17 9:25 ` [PATCH V6 3/7] cpufreq: call driver's suspend/resume for each policy Viresh Kumar
2014-03-02 0:02 ` Rafael J. Wysocki
2014-02-17 9:25 ` [PATCH V6 4/7] cpufreq: Implement cpufreq_generic_suspend() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 5/7] cpufreq: exynos: Use cpufreq_generic_suspend() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 6/7] cpufreq: s5pv210: " Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 7/7] cpufreq: Tegra: " Viresh Kumar
2014-02-18 20:30 ` [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Stephen Warren
2014-02-18 22:36 ` Rafael J. Wysocki
2014-02-18 22:26 ` Stephen Warren
2014-02-18 23:31 ` Rafael J. Wysocki
2014-02-24 6:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b79cd9aa706d988d242d80d73cfe67c0e6c5b3d.1392629003.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=jhbird.choi@samsung.com \
--cc=jinchoi@broadcom.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).