From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH] cpufreq: fix garbage kobj on errors during suspend/resume Date: Mon, 09 Dec 2013 12:53:06 +0100 Message-ID: <878uvuw89p.fsf@nemi.mork.no> References: <1386069272-9250-1-git-send-email-bjorn@mork.no> <529F04B2.7050303@linaro.org> <2628468.jr1aJZyvPu@vostro.rjw.lan> <52A567A6.6000400@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: (Martin Ziegler's message of "Mon, 09 Dec 2013 12:24:51 +0100") Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8" To: Martin Ziegler Cc: "Srivatsa S. Bhat" , Lan Tianyu , "Rafael J. Wysocki" , viresh kumar , "cpufreq@vger.kernel.org" , Linux PM list , "Rafael J. Wysocki" , martin.ziegler@math.uni-freiburg.de Martin Ziegler writes: > This works fine for cpu{1,2,3} after > > Revert "cpufreq: fix garbage kobjects on > errors during suspend/resume" > > This reverts commit > 2167e2399dc5e69c62db56d933e9c8cbe107620a. > > is applied to v3.13-rc3. There is no file cpu0/online. > > > I can check the behaviour of v3.13-rc3 itself only tomorrow, > since I am travelling. I don't think there is any need. The bug is caused by the combination of commits 2167e2399dc5 and 5a87182aa21d, and both only affect suspend/resume. CPU hotplug behaviour as such is unaffected by both patches. Bj=C3=B8rn > Am Mo 09 Dez 2013 12:18:00 CET schrieb Srivatsa S. Bhat: > >> On 12/09/2013 08:29 AM, Lan Tianyu wrote: >>> 2013/12/5 Rafael J. Wysocki : >>>> On Wednesday, December 04, 2013 04:02:18 PM viresh kumar wrote: >>>>> On Tuesday 03 December 2013 04:44 PM, Bj=C3=B8rn Mork wrote: >>>>>> This is effectively a revert of commit 5302c3fb2e62 ("cpufreq: P= erform >>>>>> light-weight init/teardown during suspend/resume"), which enable= d >>>>>> suspend/resume optimizations leaving the sysfs files in place. >> [...] >>>> I took the Bjorn's patch for 3.13 and this one I can queued up for= 3.14, >>>> but for that I guess it should contain a revert of the change made= by the >>>> Bjorn's patch. >>> >>> This patch causes a s3 regression. Cc:Martin Ziegler >>> https://bugzilla.kernel.org/show_bug.cgi?id=3D66751 >>> >> >> Hmm.. With Bjorn's patch applied, the cpufreq hotplug callback shoul= d become >> identical to what happens during regular CPU hotplug. So is regular = CPU >> hotplug also failing for you, Martin? >> >> You can do CPU hotplug by: >> >> CPU offline: >> echo 0 > /sys/devices/system/cpu/cpu/online >> >> CPU online: >> echo 1 > /sys/devices/system/cpu/cpu/online >> >> >> Bjorn's patch looks pretty innocuous to me.. I couldn't catch any ob= vious >> bug looking at the code. So answer to the above question should help= us dig >> deeper. >> >> Regards, >> Srivatsa S. Bhat >> >>