public inbox for cpufreq@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: cpufreq@vger.kernel.org
Cc: Dave Jones <davej@redhat.com>, Nishanth Menon <nm@ti.com>,
	linux-omap@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH 02/10] cpufreq: OMAP: Add SMP support for OMAP4+
Date: Thu, 22 Sep 2011 16:11:38 -0700	[thread overview]
Message-ID: <87sjnonped.fsf@ti.com> (raw)
In-Reply-To: <1316725648-26710-3-git-send-email-khilman@ti.com> (Kevin Hilman's message of "Thu, 22 Sep 2011 14:07:20 -0700")

Kevin Hilman <khilman@ti.com> writes:

> From: Russell King <rmk+kernel@arm.linux.org.uk>
>
> On OMAP SMP configuartion, both processors share the voltage
> and clock. So both CPUs needs to be scaled together and hence
> needs software co-ordination.

[...]

> diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
> index a6b2be7..f9b4c4d 100644
> --- a/drivers/cpufreq/omap-cpufreq.c
> +++ b/drivers/cpufreq/omap-cpufreq.c
> @@ -23,6 +23,7 @@
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/opp.h>
> +#include <linux/cpu.h>
>  
>  #include <asm/system.h>
>  #include <asm/smp_plat.h>

Thanks to checkpatch, I blindly removed an "#include <asm/cpu.h>" here
without re-testing.  Turns out it was important.

Added it back, and updated the version available in my
for_3.2/omap-cpufreq branch.

Kevin

  reply	other threads:[~2011-09-22 23:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 21:07 [PATCH 00/10] cpufreq: OMAP: move into drivers, cleanups/fixes for v3.2 Kevin Hilman
2011-09-22 21:07 ` [PATCH 01/10] cpufreq: OMAP: cleanup for multi-SoC support, move into drivers/cpufreq Kevin Hilman
2011-09-22 21:53   ` Tony Lindgren
2011-09-23  9:21   ` [PATCH 01/10] cpufreq: OMAP: cleanup for multi-SoC support,move " Vishwanath Sripathy
2011-09-23 14:02     ` Kevin Hilman
2011-09-22 21:07 ` [PATCH 02/10] cpufreq: OMAP: Add SMP support for OMAP4+ Kevin Hilman
2011-09-22 23:11   ` Kevin Hilman [this message]
2013-08-29 10:02   ` Viresh Kumar
2013-08-29 13:37     ` Santosh Shilimkar
2013-08-29 13:39       ` Viresh Kumar
2013-08-29 13:42         ` Santosh Shilimkar
     [not found]           ` <CAKohpomco=TodaosVbvAhFSxrth9aZ1gh+VOHftG1w6nYWBsPg@mail.gmail.com>
2013-08-30  5:58             ` Viresh Kumar
2013-08-30 13:26             ` Santosh Shilimkar
2011-09-22 21:07 ` [PATCH 03/10] cpufreq: OMAP: Enable all CPUs in shared policy mask Kevin Hilman
2011-09-22 21:07 ` [PATCH 04/10] cpufreq: OMAP: notify even with bad boot frequency Kevin Hilman
2011-09-22 21:07 ` [PATCH 05/10] cpufreq: OMAP: move clk name decision to init Kevin Hilman
2011-09-22 21:07 ` [PATCH 06/10] cpufreq: OMAP: deny initialization if no mpudev Kevin Hilman
2011-09-22 21:07 ` [PATCH 07/10] cpufreq: OMAP: dont support !freq_table Kevin Hilman
2011-09-22 21:07 ` [PATCH 08/10] cpufreq: OMAP: only supports OPP library Kevin Hilman
2011-09-22 21:07 ` [PATCH 09/10] cpufreq: OMAP: put clk if cpu_init failed Kevin Hilman
2011-09-22 21:07 ` [PATCH 10/10] cpufreq: OMAP: fix freq_table leak Kevin Hilman
2011-11-02 22:02 ` [PATCH 00/10] cpufreq: OMAP: move into drivers, cleanups/fixes for v3.2 Kevin Hilman
2011-11-02 22:08   ` Dave Jones
2011-11-02 23:37     ` Kevin Hilman
2011-11-08 19:48     ` Kevin Hilman
2011-11-08 19:59       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjnonped.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox