From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thomas Renninger <trenn@suse.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
cpufreq@vger.kernel.org, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, patches@linaro.org,
arvind.chauhan@arm.com, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com
Subject: Re: [PATCH] tools: cpufreq: Fix cpufreq-info print messages for affected[related]_cpus
Date: Tue, 2 Apr 2013 18:38:56 +0530 [thread overview]
Message-ID: <CAKohpomMdBDHPVEeHsCf5o1ABmc4CboeXsZfvf2_E3deVTdVKg@mail.gmail.com> (raw)
In-Reply-To: <3284856.AI9dTDMm0S@skinner.arch.suse.de>
On 2 April 2013 17:34, Thomas Renninger <trenn@suse.de> wrote:
> On Friday, March 29, 2013 10:40:38 PM Rafael J. Wysocki wrote:
>> On Friday, March 29, 2013 07:56:39 PM Viresh Kumar wrote:
>> > - printf(_(" CPUs which run at the same hardware frequency: "));
>> > + printf(_(" All (Online & Offline) CPUs that run at the same hardware frequency: "));
> This one is not worth changing IMO, in the end it tells the user more or less the same and
> as this stuff is translated, I'd not change it.
Okay.
>> > - printf(_(" CPUs which need to have their frequency coordinated by software: "));
>> > + printf(_(" Online CPUs that run at the same hardware frequency: "));
>> > while (cpus->next) {
> I agree that this message is more developer than user oriented,
> but cpupower is more for the end-user. So this message is not perfect.
> From what I can see of current code with patch aa77a52764a92216b61a6c8079b5c01937c046cd
> all related_cpus users are gone and related-cpus does not have any meaning at all
> anymore?
No, that's wrong. We need to set policy->cpus correctly (with online +
offline cpus) and cpufreq core will take care of setting related_cpus
with everything
from policy->cpus and policy->cpus will be modified to keep only online cpus.
> I haven't gone through your latest changes, but will at least give them a test on
> a AMD K10 multi socket machine which iirc where using related_cpus.
> I try to catch up with latest cpufreq changes as well, but wow... no idea when this
> will happen.
:)
> For now I would just leave it (cpupower messages/manpage) as it is, there is
> nothing critical which must get fixed immediately.
Yes its not really critical but it must be fixed to reflect the right stuff.
prev parent reply other threads:[~2013-04-02 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 14:26 [PATCH] tools: cpufreq: Fix cpufreq-info print messages for affected[related]_cpus Viresh Kumar
2013-03-29 21:40 ` Rafael J. Wysocki
2013-04-02 12:04 ` Thomas Renninger
2013-04-02 12:39 ` Rafael J. Wysocki
2013-04-02 13:08 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpomMdBDHPVEeHsCf5o1ABmc4CboeXsZfvf2_E3deVTdVKg@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).