cpufreq.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
@ 2014-03-11 20:41 bugzilla-daemon
  2014-03-11 23:16 ` [Bug 71931] " bugzilla-daemon
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-11 20:41 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

            Bug ID: 71931
           Summary: intel_pstate: cpufreq: __cpufreq_add_dev: ->get()
                    failed
           Product: Power Management
           Version: 2.5
    Kernel Version: 3.13.5
          Hardware: IA-32
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: cpufreq
          Assignee: cpufreq@vger.kernel.org
          Reporter: patrik.lundquist@gmail.com
                CC: dirk.brandewie@gmail.com
        Regression: No

Booting 3.13.5 on a dual socket Ivy Bridge-EP resulted in this error:

[    0.194139] smpboot: CPU0: Intel(R) Xeon(R) CPU E5-2687W v2 @ 3.40GHz (fam:
06, model: 3e, stepping: 04)
...
[    0.246755] x86: Booting SMP configuration:
[    0.250935] .... node  #0, CPUs:        #1  #2  #3  #4  #5  #6  #7
[    0.357648] .... node  #1, CPUs:    #8  #9 #10 #11 #12 #13 #14 #15
[    0.553293] x86: Booted up 2 nodes, 16 CPUs
[    0.557666] smpboot: Total of 16 processors activated (108850.19 BogoMIPS)
...
[    5.210204] Intel P-state driver initializing.
[    5.232407] Intel pstate controlling: cpu 0
[    5.253628] Intel pstate controlling: cpu 1
[    5.274899] cpufreq: __cpufreq_add_dev: ->get() failed
[    5.294856] Intel pstate controlling: cpu 2
[    5.313553] Intel pstate controlling: cpu 3
[    5.332526] Intel pstate controlling: cpu 4
[    5.352347] Intel pstate controlling: cpu 5
[    5.372112] Intel pstate controlling: cpu 6
[    5.391097] Intel pstate controlling: cpu 7
[    5.410272] Intel pstate controlling: cpu 8
[    5.429092] Intel pstate controlling: cpu 9
[    5.447714] Intel pstate controlling: cpu 10
[    5.465872] Intel pstate controlling: cpu 11
[    5.482942] Intel pstate controlling: cpu 12
[    5.498414] Intel pstate controlling: cpu 13
[    5.513586] Intel pstate controlling: cpu 14
[    5.529200] Intel pstate controlling: cpu 15

CPU 1 is alive and well but missing the cpufreq driver. The system is running
fine otherwise.

Looking closer at the problem gives that intel_pstate_init_cpu() is successful
but intel_pstate_get(), which is called right after by cpufreq, fails.

Since all_cpu_data[1] is initialized it gives that sample->freq must be zero.
So the bug should be in intel_pstate_calc_busy() which calculates sample->freq
to zero.

core_pct is likely 0 due to truncation in
intel_pstate.c:intel_pstate_calc_busy():

    core_pct = div64_u64(int_tofp(sample->aperf * 100),
                 sample->mperf);

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 71931] intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
  2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
@ 2014-03-11 23:16 ` bugzilla-daemon
  2014-03-12 11:18 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-11 23:16 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

Rafael J. Wysocki <rjw@rjwysocki.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rjw@rjwysocki.net
         Regression|No                          |Yes

--- Comment #1 from Rafael J. Wysocki <rjw@rjwysocki.net> ---
Patch: https://patchwork.kernel.org/patch/3814781/

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 71931] intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
  2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
  2014-03-11 23:16 ` [Bug 71931] " bugzilla-daemon
@ 2014-03-12 11:18 ` bugzilla-daemon
  2014-03-12 11:19 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-12 11:18 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

--- Comment #2 from Rafael J. Wysocki <rjw@rjwysocki.net> ---
Created attachment 129151
  --> https://bugzilla.kernel.org/attachment.cgi?id=129151&action=edit
cpufreq: Skip current frequency initialization for ->setpolicy drivers

Attached again with a changelog and stuff.  Please test!

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 71931] intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
  2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
  2014-03-11 23:16 ` [Bug 71931] " bugzilla-daemon
  2014-03-12 11:18 ` bugzilla-daemon
@ 2014-03-12 11:19 ` bugzilla-daemon
  2014-03-12 20:52 ` bugzilla-daemon
  2014-03-17  3:18 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-12 11:19 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

Rafael J. Wysocki <rjw@rjwysocki.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 71931] intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
  2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
                   ` (2 preceding siblings ...)
  2014-03-12 11:19 ` bugzilla-daemon
@ 2014-03-12 20:52 ` bugzilla-daemon
  2014-03-17  3:18 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-12 20:52 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

--- Comment #3 from Patrik Lundquist <patrik.lundquist@gmail.com> ---
Patch tested on an Intel Xeon CPU E3-1240 V2 @ 3.40GHz (fam: 06, model: 3a,
stepping: 09) which is also an Ivy Bridge.

The intel_pstate driver loads fine and cpufreq_driver->get() is no longer
called when cpufreq adds the CPUs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 71931] intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed
  2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
                   ` (3 preceding siblings ...)
  2014-03-12 20:52 ` bugzilla-daemon
@ 2014-03-17  3:18 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2014-03-17  3:18 UTC (permalink / raw)
  To: cpufreq

https://bugzilla.kernel.org/show_bug.cgi?id=71931

Lan Tianyu <tianyu.lan@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |CLOSED
                 CC|                            |tianyu.lan@intel.com
         Resolution|---                         |PATCH_ALREADY_AVAILABLE

--- Comment #4 from Lan Tianyu <tianyu.lan@intel.com> ---
The patch has been merged into linux-pm tree.
http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?id=2ed99e39cb9392312c100d9da591c20641c64d12

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-03-17  3:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11 20:41 [Bug 71931] New: intel_pstate: cpufreq: __cpufreq_add_dev: ->get() failed bugzilla-daemon
2014-03-11 23:16 ` [Bug 71931] " bugzilla-daemon
2014-03-12 11:18 ` bugzilla-daemon
2014-03-12 11:19 ` bugzilla-daemon
2014-03-12 20:52 ` bugzilla-daemon
2014-03-17  3:18 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).