From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2645E26CE22 for ; Sat, 29 Nov 2025 09:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764407721; cv=none; b=thZq1Y3uK6MSxLyjk2mywbpXf+95craz79IScmkoT3/USLLh75XofOeI5FKPIBKDjBbNSsjsMHo7+fMeJHIxKoPU6qMWRTVUhfaTl01xZg75p6C1Jm4r43HrqejepS3jXvq8Xymy0fivFYFwmlzhFYefSAS9jm96tQDv0mQSE1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764407721; c=relaxed/simple; bh=1H3tSySb8RYZ9Xz952vACbtvWTupkLqx1w90JROwSJk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GCHc8zzoYa7SRlhzIFCt63OAeQt4Owi7ptI4Kyk3KwA4N6E7YWYGChAOG5u6MlJCsCFB49A+lJonNUqOwIIUdVt+rfeAbe4u0VB6g8EQhm8TZEidFSaDBa1TrNTq02Uo5NjnGDIBmHyI1TuNyU7KpJn/1zb9/7jIYPpJZkl724Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XbGvwwXA; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XbGvwwXA" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7aad4823079so2265689b3a.0 for ; Sat, 29 Nov 2025 01:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764407719; x=1765012519; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTLbYX7bNTCm4TW5N/uHN1/H0O/wwjH+DS42MIfV7UI=; b=XbGvwwXA8+1VzSTe/hXfZNl1rlmjsSjhKxVvYKnB+si4SEMjpZyrziatmjRgNHvX6+ MoS9uhm8zx6UHaF/UNkdOsbMlGA3SlyOeXIP4+nLyPmH0WqQNW6DUdOK1fRtEh98i+7H eBBu4VFRb0a+BnNODguzcKqGGVCvjN0FZcGF7QBX4sIheyv4vMe5u0UBbiN4bH6xsTDI urF/surapAQ1+bkk3W3FWBTbrozOSIkqRHrGKKwgQUWN3KricAR/rVG4kNZheuXZaFAp C65WRvutm3QmVk9Da8e5rABA2btHlW0Y/ioT1dSHOLXlVHiUNQzqYPUodSM85q9Sa7jO aDqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764407719; x=1765012519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RTLbYX7bNTCm4TW5N/uHN1/H0O/wwjH+DS42MIfV7UI=; b=OfpYBqZbd/qFbeedmP+DtVuVoBu2tL3stdSPwc8Jn1AR6ra2UWBrB/HijXU1RKyWse Gw53KrN5acoG964+yQ5GK/3Xal26zDrCcHqDvpZWtGvanQMlan0eX5LswN/Pn9dH6fv2 0N7+CNFPXmFvpXjIh6m/gp3GF3dtMman9UaJrD065q6CJWQfadAxp19wTlv5oEbP3+bt AZstwTcn2kneUz4e9kFj4cPlS00SlA0Mt32rznSk0jB3+Ys3B5zZYGloMKjbgWeOn9no m/yWMObDjQxpqPMgxaO5NE5Ctt3CKezVnbbH8EGc7MQvrI1XhuanuQJnVbSmCkcsVr8e coWw== X-Forwarded-Encrypted: i=1; AJvYcCUoPoxNfhGy8kf0kp0JHjT4tbsfkL+ZmWPTjE87WsQ/QEcIKPnAj4Eiu5WSg0KwjKRrIhq1@lists.linux.dev X-Gm-Message-State: AOJu0Yxtu3ibrMe+w/TQFa2xtDSP9QqVra03VnUSqAjB8t1Pp3xa1/uq 0CQ7bFDiG98qKFSeVH7r+PjEjpMXObLGWOGM84FdfCNay6l5bIGB8Iqo X-Gm-Gg: ASbGncsTqZkIkecMpg+CiyiYY+ueuBAFeP0pDCwJ60oQqEc16wFA1sqqmnsE/MEk4gy gUWaV2iPSKPuDq9os4HZhoWBtvROPv7psQMUwYSxTRAoTwzMvSha7eadaOuR1MjsyqIGia65Dnt vqJlP0ps+vdcs/YCQcvy+JKKsKjm8rPunfxpBbamPAl390hJVyLUKtLyYqxoIWB01TxW5P8q2Gk FFJxoAa2MfILOpauBU/mpl02uuYKCalBb5cXnq1AA4I1nRHmXWFjL82tWVgx1RBkAnsQghhBYho A9TulGCR/9NzjjJFjN9QkkZvU5RBveSSgZdVTuyXkDG0XlbtW2zNRpCTax8PP29Mz9rjxPDb7r6 KePt66kYR1AWJDp+Tg5B4Kx05yyOyyUtfhTUSasRSMUHYsYaQSgfGCMEkJr6C1w9kmAAJVZRhTc sABqKlzmLNpgc= X-Google-Smtp-Source: AGHT+IFKJjzpV9EYUo0mUxqBF81hGWIOAODYyB9YBLMIQiF1odGWwtu4fNZsuEorPfh62DeARpYtCA== X-Received: by 2002:a05:6a00:2293:b0:7ab:995a:46b0 with SMTP id d2e1a72fcca58-7c58e110869mr34201519b3a.15.1764407719096; Sat, 29 Nov 2025 01:15:19 -0800 (PST) Received: from fedora ([2405:201:3017:184:2d1c:8c4c:2945:3f7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15e7db416sm7300563b3a.41.2025.11.29.01.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 01:15:18 -0800 (PST) From: Bhavik Sachdev To: Alexander Viro , Christian Brauner , Shuah Khan Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, criu@lists.linux.dev, Jan Kara , Jeff Layton , Aleksa Sarai , Miklos Szeredi , Bhavik Sachdev , Pavel Tikhomirov , Andrei Vagin , Alexander Mikhalitsyn , John Hubbard , Amir Goldstein , "Martin K . Petersen" , Andrew Donnellan Subject: [PATCH v7 1/3] statmount: permission check should return EPERM Date: Sat, 29 Nov 2025 14:41:20 +0530 Message-ID: <20251129091455.757724-2-b.sachdev1904@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251129091455.757724-1-b.sachdev1904@gmail.com> References: <20251129091455.757724-1-b.sachdev1904@gmail.com> Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, statmount() returns ENOENT when caller is not CAP_SYS_ADMIN in the user namespace owner of target mount namespace. This should be EPERM instead. Suggested-by: Miklos Szeredi Signed-off-by: Bhavik Sachdev --- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namespace.c b/fs/namespace.c index 2bad25709b2c..ee36d67f1ac2 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -5795,7 +5795,7 @@ SYSCALL_DEFINE4(statmount, const struct mnt_id_req __user *, req, if (kreq.mnt_ns_id && (ns != current->nsproxy->mnt_ns) && !ns_capable_noaudit(ns->user_ns, CAP_SYS_ADMIN)) - return -ENOENT; + return -EPERM; ks = kmalloc(sizeof(*ks), GFP_KERNEL_ACCOUNT); if (!ks) -- 2.52.0