From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010042.outbound.protection.outlook.com [52.101.201.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F4F3CB2DB for ; Fri, 10 Apr 2026 14:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.42 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775832331; cv=fail; b=OA5kpn+PBbaEp8mJj8rFPgG2UNTtZOVw9eAH82S/HKWdIjrNaHQlv3eBhsLyjIjKiu0PRVV1WEWy4Ytk9dnT3+DCaHVV0Vs8dbufGRvBZkZAL2Jg2O1tW3BXxeyJC3gxANwZVLNW6zzE1g/aDyla2c/7FHnyuc/P/nUqz+dlA7k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775832331; c=relaxed/simple; bh=dD9STAyItW7Orjfh/hS3254iU3jpB52/oOOqxiiHcqs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lB4RGw9uOCsP/9geKXCle0QcQPrM8mUwQ+S4jQREQJ5sRRYrnDLhWVFd8smyB/T51g70tE7mTp91+9HDZmOHT+lTaSZ6fZFRtyRzFWKFAfZiwC4H68EepJYpp/qtC2Mwlwi2CkZcAIosgQnl5j/LZmQr0Krec8k1ewNluykFrEw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=UrBqo+ah; arc=fail smtp.client-ip=52.101.201.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="UrBqo+ah" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jI3jebLdcpD4ST4UBuCqfY9RKoufgX/EBj1BUoamyzB9XGxPQFL/LFYmEukyaFIKzGkOjOJJ+wDc4hHNclXqMvycgXnI5RPHnv63A6S8frjUc6fvUwRkQ2U4WAVeAbA5UhMPLMfDNIQSmCGsA8AU9MR8p94tFXTyOiEgelAFMHrJGBkdAYiZ65zsynm+uBEjleWyJo24pTd2KfqY8jjokk07YwD1PnOBZ+1sLlhAVb3xRt5dgRRiv/ZSlXqxDjIki/gOVxmUHmuVv+rXUcwlMf2JyNhKWwYt9OjPE73ZOhengb+r8eWEq7iACIUOf+TlUJPa1h8lRPMeF36g1AmPBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Mvy6smsnR92e0rU8u9/9GnbOTmKP/LcqEjptcPioTY=; b=wtyycB221SZknGX8FvXtC3p2adTzp9lgSt0abwo5G2nlj05zR/QDBKf8ABHyOGxK56siCcE6pdC9qlHCEjYrwMzltzr5AbiUjASUFeSbArH1I6M/KSt0i7f8uV6hMC/IneiiAW7fB4OrQq+pDr2sNS6iWextW39QoANqn4vE5qbnUxWJZ+2ZZcMGXTei5yIHQtaFYmFrI9t0Ixz5qCnsfLmD3wIlpnBNWDi33FHUpSS6aIY0JbOfS9u/Z1oZHyU7BVNQ/r/7YuzJR8SkNg9oBmxOHzICQyDv575iTcIJQLdgiOv9/tgPRjBx+ws9ZnC+352wra23j7WbEv+l4Eoa0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.linux.dev smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Mvy6smsnR92e0rU8u9/9GnbOTmKP/LcqEjptcPioTY=; b=UrBqo+ahaYv89+awMPYFkHzrEClkUwqEFqmTcb4GYwQqrQsXv592hF3+LCXoJy+CSJ+8GoDlp1vMJvC4LL+3ccZWnJR4+LTiuCjOxbYHYo+kpUgXFbwiJiar3jc3m2HbZVVQAkGCj2peto+ObN9cMoKLzbeBz2n0kzTxeaT4azs= Received: from BN0PR02CA0017.namprd02.prod.outlook.com (2603:10b6:408:e4::22) by DM4PR12MB6109.namprd12.prod.outlook.com (2603:10b6:8:ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9791.32; Fri, 10 Apr 2026 14:45:25 +0000 Received: from BN2PEPF00004FBA.namprd04.prod.outlook.com (2603:10b6:408:e4:cafe::d2) by BN0PR02CA0017.outlook.office365.com (2603:10b6:408:e4::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.42 via Frontend Transport; Fri, 10 Apr 2026 14:44:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BN2PEPF00004FBA.mail.protection.outlook.com (10.167.243.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Fri, 10 Apr 2026 14:45:25 +0000 Received: from fdavid-dev.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 10 Apr 2026 09:45:25 -0500 From: David Francis To: CC: , David Francis Subject: [PATCH 1/3] plugin/amdgpu: Add plugin to inventory even if there are no vmas Date: Fri, 10 Apr 2026 10:45:07 -0400 Message-ID: <20260410144509.738903-2-David.Francis@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260410144509.738903-1-David.Francis@amd.com> References: <20260410144509.738903-1-David.Francis@amd.com> Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBA:EE_|DM4PR12MB6109:EE_ X-MS-Office365-Filtering-Correlation-Id: de4ae2b4-3b76-4bb4-5520-08de970fcd4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: NxWZEP3RL0qwXKVe7aMeTjP1R4GoIR1O1Wxoua1SSxqGAvDcZ0INL/RvygrE2oZNDsRsXoudk4N1P4tF1qdxgON02uH9fjEtaAgujvUVL9W8e88S+8EXUzYTQpcrV5E0AlwvPZg5t6W/eCWNFNBftFKjGEJoQ/IeZPdVJslAeFVLxqDmMuARc359R/IJz/aKGX9FUZ7qO91erqnYTNgn0sjw78men5G2AJZbFUqCeHtL5TNVtJ23XqKw2Elrjh077KIqFIHkG/AQ1R0AeEa5wkHp2PguFASMDoE798WUSpmJiWN6eSQSsEkg00tSy6bEecOnoaLjHpJklp3JRfjWL8C3aiWOHvXCqBiaH05wYLgyuYk9A+MIQGsPmACQsMsuhGgwGhDVVerhD0wEWkTIGJhrzjm+JPErOd9aJE+KBjbrjcizBnpEil2SlENxvVSERhLDZ1LBHtwzcAGafTiMSQvWHiXbx6g8OT37EgKmsuveqVTDy2P1oT7bhdxw+1OYpK+MjvqXGgrP546V2l9rUo0tv+TCOzvrsvzbHqmQYn1RFeGyTw6SKp4wT5UXx3cvc1z6l1/VMsx+0YW+F9wbj4I8AvPsIQ3Z4diHxTOhRd+XEIvQMR71Hl6O996dQT0dqLMX0zFZXyRoQ/SDOj3oe4HIKQ6cNEgB4eE25fLgWnnHSIWw/LVLOOvTiLK1SAA2mbjOtaXomWyLscggpncvkst19Ys/UUaRnEji3zurI4LvV5xkF2VMIx5vlfRFmHHy+uhzENJ5lwAMU1M2s087Gg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9BkadSxB8+DeuqHwiOmX4MjRrnRktLkVBwA+RQWCpRaPD/GWVjR12C2Nf82WV+F8N2xzEWyOvm9FSfN3JAQPwhCk63+Xg9Jhgpo/EEJes4TcgvIe21ejH7i0xWz6/Sgdez5YY7G7bJ9M0VdFFGkJdjOjCXqL46tG3zySl8bHM5PUYVnjxT9+4DK53r2DWNSIdIXrtMKT5xU5Da1azRosePMy0zdFurg5HRK/6Wb9zsZxitBjbhp9cpbQz2vHxNyaWJeTgKkn2HGE79guTf+1KXIjUeoprLHL5oOOKQ/FsmM05K/0FIm03yAo3/suMUulORTd+vFgzTRDM/+8utiAuMZme1+dERleUit8ppZPHBsKWFkXF8eUOK8DR+u7ljFx0oDyAEfejHFpLT2DtPkMx/6HdqituTIdkcoLMFwmpG8K6QQjFxMIo+khUEheQ74+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2026 14:45:25.7528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de4ae2b4-3b76-4bb4-5520-08de970fcd4e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6109 The amdgpu plugin is added to the plugin inventory as the first vma map is dumped. But it's completely possible for a process to have driver files open but no vma maps. In this case, we still will need the plugin on restore. Add the plugin to the inventory whenever a device file is dumped. Signed-off-by: David Francis --- plugins/amdgpu/amdgpu_plugin.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/plugins/amdgpu/amdgpu_plugin.c b/plugins/amdgpu/amdgpu_plugin.c index e3ba0de64..89ab10dac 100644 --- a/plugins/amdgpu/amdgpu_plugin.c +++ b/plugins/amdgpu/amdgpu_plugin.c @@ -1439,6 +1439,15 @@ int amdgpu_plugin_dump_file(int fd, int id) if (ret) return ret; + if (!plugin_added_to_inventory) { + ret = add_inventory_plugin(CR_PLUGIN_DESC.name); + if (ret) { + pr_err("Failed to add AMDGPU plugin to inventory image\n"); + return ret; + } + plugin_added_to_inventory = true; + } + ret = record_dumped_fd(fd, true); if (ret) return ret; @@ -1543,6 +1552,15 @@ int amdgpu_plugin_dump_file(int fd, int id) if (ret) goto exit; + if (!plugin_added_to_inventory) { + ret = add_inventory_plugin(CR_PLUGIN_DESC.name); + if (ret) { + pr_err("Failed to add AMDGPU plugin to inventory image\n"); + goto exit; + } + plugin_added_to_inventory = true; + } + exit: xfree((void *)args.devices); xfree((void *)args.bos); -- 2.34.1