From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A214F36E493 for ; Mon, 13 Apr 2026 19:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776109645; cv=none; b=dzbOMxJjBgIOd3XCNUSV4+2Jzz31B0hD+Jg1EJvmjIuZzMoIHrioUkOX0Io64qwTGDb0+qbs3crVKhakrRgrl/CAmulBwJuIZJ0MqfJ+5Xi1LbBKGrNOmphmRU57q14q8p0uopiU42hQg5CTo/W5f3ZPOW+1YxXzlzRoZPqhd6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776109645; c=relaxed/simple; bh=5Jdl69HSh3uRDx4g4OTm4cODT3OzAH262NUp8yscMK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e0tDWGlZn7pNEMidP7+EK3voQBPBK7LZZdaJiANHF3N1nLdj/jmQKUiTvteATID0m/ftwqOzcqwq7m1jFNxzb8hvmel2d8F1s5Ope4ZFzJ6fri2A3O1FzKdOluP2NELZuXojc4S54TA9hYtUfHJvpTc9NFYa/e0evT/5mE02qGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=Mx+ECCwB; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Mx+ECCwB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/juQP2ZaZGM/A2RPEdQqN+dtdcQ8s1d36pnqzlIDsrI=; b=Mx+ECCwB23RD/4opz8hAC+HBNC 0uVMoG7owUoN/Zj4R7o0t23uZXrAviEycBP3e52ZLm5pSztz8sW4ZnbU5xOYNZBpVKU4GCNnTZ0bH ZmZwKpiQcL/J7vnCcXYL3NwK6Zlq48iffMwlyGcbr/2Kw2Y4akUTjw/EQlrYEDQV6p2+ZC+95SYXv q7vzSZJ+Bk5Rnf71LxdUaZ1h20fQL8zeqllyEgJJxGKkkCmWtqRbfv8w2ySHS7TcwrVqWak0bgXTP ND60pR+iD4v7Jj5cNJlwO1x5ut7l5Imuj/8JD5KQ90V/rVU12X0uyDLzX3+QzlvMy+TsIrskxorKO OsMiLB9A==; Received: from [90.240.106.137] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1wCNFf-00FZnX-1j; Mon, 13 Apr 2026 21:47:19 +0200 Message-ID: <85ea39dc-48e2-41cc-8d0c-b96e76ec9f46@igalia.com> Date: Mon, 13 Apr 2026 20:47:17 +0100 Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/23] Amdgpu plugin cleanups and fixes To: Andrei Vagin Cc: criu@lists.linux.dev, Radostin Stoyanov , David Francis References: <20260410185514.51153-1-tvrtko.ursulin@igalia.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrei, On 13/04/2026 19:23, Andrei Vagin wrote: > On Fri, Apr 10, 2026 at 11:55 AM Tvrtko Ursulin > wrote: >> >> This series is a subset of previously posted as RFC: >> https://lore.kernel.org/criu/CAEWA0a4ghpPeQjg1ETiQysGj5agfWwJRvMbWzhrYL5r8WZ5H7Q@mail.gmail.com/T/#mfb4ab4866a0cb440961be7170d0e107fab7eedf2 >> >> And as v1 cleanups only: >> https://lore.kernel.org/criu/5e99e181-6e19-4b7d-8c10-a846ed4e74a3@igalia.com/T/#md4284ded141876b7d7b942d2d449d6100bd20a2e >> >> It still only contains the fixes and cleanups with the render node hacks >> removed. >> >> All patches have now been reviewed, although from v1 to v2 it was a difficult >> rebase do upstream movement that happened in the meantime. So I think it would >> be good to smoke test it in an environemnt other than where I tested using my >> amd_criu IGT. >> >> Two patches have been dropped from the series: >> >> plugins/amdgpu: Check images were opened successfully >> plugins/amdgpu: Fix error handling in amdgpu_plugin_drm_restore_file() >> >> The same fixes have since been implemented in upstream at least in: >> >> 611af0188dfe ("plugin/amdgpu: add open_img_file error handling") >> 16b252ee21a8 ("plugin/amdgpu: add missing xzalloc() NULL checks in drm") >> >> Fingers crossed I have not messed up anything in this relatively extensive >> rebase and ideally we can merge this sooner rather than later and carry on >> working on top. > > Tvrtko, > > could you please review comments and ci failures: > https://github.com/checkpoint-restore/criu/pull/2999 Sure thing, I was not aware there is all that infra. Also, if I switch away from the mailing list workflow, presumably I can get these reports for pull requests I make? Regards, Tvrtko