Re: [PATCH 0/2] Bitlocker: Support clearkey

[Milan Broz <gmazyland@gmail.com>]

On 10/4/25 2:35 AM, Kfir Kahanov wrote:
> This code enable support for clearkey bitlocker protection.
> Closes: #962

Hi,

as this is not trivial feature, please submit it through
merge request through GitLab project page.
You already have issue there, so it should not be a problem.

This way it can go through CI and all discussion and changes
will be there. Also it need to include some tests.

For the patch - we planned support for Bitlocker clearkey,
so it is definitely something that I would lite to merge.

However, I do not understand why you need to touch API
and other formats. The whole implementation should be embedded
in BITLK format support only.
IMO if Bitlocker header contains CLEARKEY, it should be used
directly. I know it will be a little bit tricky to support
it through existing calls, but I definitely do not want new activation
API call and commandline option for it.

Anyway, this discussion should happen on Gitlab, we can
discuss there possible options for integration.

Thanks!
Milan


> 
> 
> Kfir Kahanov (2):
>    bitlocker: Support clearkey
>    bitlocker: Add clearkey option
> 
>   lib/bitlk/bitlk.c         | 106 +++++++++++++++++++++++++-------------
>   lib/keyslot_context.c     |  97 ++++++++++++++++++++++++++++++++++
>   lib/keyslot_context.h     |   2 +
>   lib/libcryptsetup.h       |  24 +++++++++
>   lib/libcryptsetup.sym     |   1 +
>   lib/setup.c               |  24 ++++++++-
>   src/cryptsetup.c          |  20 ++++---
>   src/cryptsetup_arg_list.h |   2 +
>   src/cryptsetup_args.h     |   1 +
>   src/utils_arg_names.h     |   1 +
>   10 files changed, 234 insertions(+), 44 deletions(-)
>