From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25781171D9; Mon, 4 Dec 2023 17:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iGvBZLtY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5F8C433C7; Mon, 4 Dec 2023 17:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701709269; bh=PrQN3LxsLo0hnYtX+mHxOw3BE7UQ018hcELFYEAwoxQ=; h=From:To:Cc:Subject:Date:From; b=iGvBZLtYs7yHtlLTahRlEyaMg77PkPNKCUnY79j+4a+CQ0rzo/s8oWQILhuPdvPah DXg32bDyS/S+oRwZ/rTx+ePKScRNqgIcPlsFAlXdMrwxfzGqc/48qdxze/hx9zZHv4 FfghEKC/+5gGgaUZUYSWaVNMcBHvC9WDKTVAyXUxCVQle9dgrLwZnKVMwRjumzvyKy HbwQ/G80otDrUBS13rwTJK+5hCsXWO8VYjkXJ2AmSvqeNrKo26vG+Mbn2ej+ak+6lJ PbYedmzbC9cXA0f/a4J9cx2Kos0QLDzgLekg7WZItSI4QvlSTYhLxm1CwwCc8yiVcC BIrLl4SrYaj5Q== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Stephen Rothwell , damon@lists.linux.dev, linux-mm@kvack.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-unstable] mm/damon: document get_score_arg field of struct damos_quota Date: Mon, 4 Dec 2023 17:01:06 +0000 Message-Id: <20231204170106.60992-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable missed documenting 'get_score_arg' field of 'struct damos_quota' on the kernel-doc comment. Fix it. Fixes: 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable Signed-off-by: SeongJae Park --- include/linux/damon.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 508a262418a2..aa34ab433bc5 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -137,6 +137,7 @@ enum damos_action { * @weight_age: Weight of the region's age for prioritization. * * @get_score: Feedback function for self-tuning quota. + * @get_score_arg: Parameter for @get_score * * To avoid consuming too much CPU time or IO resources for applying the * &struct damos->action to large memory, DAMON allows users to set time and/or @@ -156,10 +157,10 @@ enum damos_action { * &weight_nr_accesses, and &weight_age, because monitoring operations are * encouraged to respect those. * - * If @get_score function pointer is set, DAMON calls it back and get the - * return value of it for every @reset_interval. Then, DAMON adjusts the - * effective quota using the return value as a feedback score to the current - * quota, using its internal feedback loop algorithm. + * If @get_score function pointer is set, DAMON calls it back with + * @get_score_arg and get the return value of it for every @reset_interval. + * Then, DAMON adjusts the effective quota using the return value as a feedback + * score to the current quota, using its internal feedback loop algorithm. * * The feedback loop algorithem assumes the quota input and the feedback score * output are in a positive proportional relationship, and the goal of the -- 2.34.1