Re: [PATCH] mm/damon/core: Refactor damos_set_effective_quota

[SeongJae Park <sj@kernel.org>]

On Mon, 25 Nov 2024 13:49:33 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:

> On Fri, 22 Nov 2024 11:29:26 -0800 SeongJae Park <sj@kernel.org> wrote:
> > Hi Honggyu,
> > 
> > 
> > Thank you for this patch.  Definitely DAMON needs many refactoring and
> > cleanups.
> > 
> > The subject of the patch is a little bit ambiguous to me.  Could we make it
> > more specific, e.g., "set esz of damos_set_effective_quota() as ULONG_MAX by
> > default"?
> 
> Hi SeongJae,
> 
> Thanks for the review, but IMHO, setting the default value of esz is to remove
> one of duplicate if statement, not the goal of this patch.
> 
> So I think the following title might be better.
> 
>   mm/damon/core: remove duplicate list_empty quota->goals check
> 
> Is this okay for you?

Yes, this looks specific and non-ambiguous enough to me.

[...]
> > > --- a/mm/damon/core.c
> > > +++ b/mm/damon/core.c
> > > @@ -1542,7 +1542,7 @@ static unsigned long damos_quota_score(struct damos_quota *quota)
> > >  static void damos_set_effective_quota(struct damos_quota *quota)
> > >  {
> > >  	unsigned long throughput;
> > > -	unsigned long esz;
> > > +	unsigned long esz = UINT_MAX;
> > 
> > Let's use ULONG_MAX.
> 
> Ack. I will apply this and send v2 soon.

Thank you, I will review it soon :)


Thanks,
SJ

[...]