From: SeongJae Park <sj@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: SeongJae Park <sj@kernel.org>,
oe-kbuild-all@lists.linux.dev, damon@lists.linux.dev
Subject: Re: [sj:damon/next 62/72] mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 'sysfs_schemes' not described in 'damos_sysfs_populate_region_dir'
Date: Mon, 2 Dec 2024 11:01:33 -0800 [thread overview]
Message-ID: <20241202190133.57122-1-sj@kernel.org> (raw)
In-Reply-To: <202412020702.S7FyZSzV-lkp@intel.com>
On Mon, 2 Dec 2024 07:55:43 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head: b75cfd5260e9e512e1075267a70283e53e661357
> commit: 2385753a6db33141791a25d611e6e5b63a9ddc4d [62/72] mm/damon/sysfs: use damos_walk() for schemes tried regions update
> config: x86_64-buildonly-randconfig-003-20241202 (https://download.01.org/0day-ci/archive/20241202/202412020702.S7FyZSzV-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241202/202412020702.S7FyZSzV-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412020702.S7FyZSzV-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 'sysfs_schemes' not described in 'damos_sysfs_populate_region_dir'
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 'ctx' not described in 'damos_sysfs_populate_region_dir'
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 't' not described in 'damos_sysfs_populate_region_dir'
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 'r' not described in 'damos_sysfs_populate_region_dir'
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 's' not described in 'damos_sysfs_populate_region_dir'
> >> mm/damon/sysfs-schemes.c:2199: warning: Function parameter or struct member 'total_bytes_only' not described in 'damos_sysfs_populate_region_dir'
>
>
> vim +2199 mm/damon/sysfs-schemes.c
>
> 2190
> 2191 /**
> 2192 * damos_sysfs_populate_region_dir() - Populate a schemes tried region dir.
> 2193 *
> 2194 * Called from DAMOS walk callback while holding damon_sysfs_lock.
> 2195 */
> 2196 void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
> 2197 struct damon_ctx *ctx, struct damon_target *t,
> 2198 struct damon_region *r, struct damos *s, bool total_bytes_only)
> > 2199 {
Thank you for reporting! I just pushed the fix:
https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=04df30e0d8b2a8cd60873ebaf029414a6bcc4643
Thanks,
SJ
[...]
parent reply other threads:[~2024-12-02 19:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <202412020702.S7FyZSzV-lkp@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202190133.57122-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox