Re: [PATCH 8/8] memcg: rename mem_cgroup_ino() to mem_cgroup_id()

kernel test robot
2025-12-26T12:32:21Z

Hi Shakeel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on sj/damon/next]
[cannot apply to akpm-mm/mm-everything tj-cgroup/for-next linus/master v6.19-rc2 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/memcg-introduce-private-id-API-for-in-kernel-users/20251226-072954
base: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
patch link: https://lore.kernel.org/r/20251225232116.294540-9-shakeel.butt%40linux.dev
patch subject: [PATCH 8/8] memcg: rename mem_cgroup_ino() to mem_cgroup_id()
config: arm64-randconfig-001-20251226 (https://download.01.org/0day-ci/archive/20251226/202512262045.CkWwCNp7-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251226/202512262045.CkWwCNp7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512262045.CkWwCNp7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/damon/sysfs.c:2704:33: warning: format specifies type 'unsigned int' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
2704 | pr_info("id: %u, path: %s\n", mem_cgroup_id(memcg), path);
| ~~ ^~~~~~~~~~~~~~~~~~~~
| %llu
include/linux/printk.h:585:34: note: expanded from macro 'pr_info'
585 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:512:60: note: expanded from macro 'printk'
512 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:484:19: note: expanded from macro 'printk_index_wrap'
484 | _p_func(_fmt, ##__VA_ARGS__); \
| ~~~~ ^~~~~~~~~~~
1 warning generated.

vim +2704 mm/damon/sysfs.c

c951cd3b89010c SeongJae Park 2022-03-22 2690
a25dadf8af8ddc SeongJae Park 2022-11-18 2691 static ssize_t debug_show(struct kobject *kobj,
a25dadf8af8ddc SeongJae Park 2022-11-18 2692 struct kobj_attribute *attr, char *buf)
a25dadf8af8ddc SeongJae Park 2022-11-18 2693 {
a25dadf8af8ddc SeongJae Park 2022-11-18 2694 #ifdef CONFIG_MEMCG
a25dadf8af8ddc SeongJae Park 2022-11-18 2695 struct mem_cgroup *memcg;
a25dadf8af8ddc SeongJae Park 2022-11-18 2696 char *path = kmalloc(sizeof(*path) * PATH_MAX, GFP_KERNEL);
a25dadf8af8ddc SeongJae Park 2022-11-18 2697
a25dadf8af8ddc SeongJae Park 2022-11-18 2698 if (!path)
a25dadf8af8ddc SeongJae Park 2022-11-18 2699 return -ENOMEM;
a25dadf8af8ddc SeongJae Park 2022-11-18 2700
a25dadf8af8ddc SeongJae Park 2022-11-18 2701 for (memcg = mem_cgroup_iter(NULL, NULL, NULL); memcg; memcg =
a25dadf8af8ddc SeongJae Park 2022-11-18 2702 mem_cgroup_iter(NULL, memcg, NULL)) {
a25dadf8af8ddc SeongJae Park 2022-11-18 2703 cgroup_path(memcg->css.cgroup, path, PATH_MAX);
a25dadf8af8ddc SeongJae Park 2022-11-18 @2704 pr_info("id: %u, path: %s\n", mem_cgroup_id(memcg), path);
a25dadf8af8ddc SeongJae Park 2022-11-18 2705 }
a25dadf8af8ddc SeongJae Park 2022-11-18 2706
a25dadf8af8ddc SeongJae Park 2022-11-18 2707 kfree(path);
a25dadf8af8ddc SeongJae Park 2022-11-18 2708 #endif
a25dadf8af8ddc SeongJae Park 2022-11-18 2709
a25dadf8af8ddc SeongJae Park 2022-11-18 2710 return 0;
a25dadf8af8ddc SeongJae Park 2022-11-18 2711 }
a25dadf8af8ddc SeongJae Park 2022-11-18 2712

--
0-DAY CI Kernel Test Service