* [PATCH 5.15.y] mm/damon/tests/core-kunit: handle memory alloc failure from damon_test_aggregate()
[not found] <2026010546-gibberish-fracture-b6c1@gregkh>
@ 2026-01-06 2:20 ` SeongJae Park
0 siblings, 0 replies; only message in thread
From: SeongJae Park @ 2026-01-06 2:20 UTC (permalink / raw)
To: stable
Cc: damon, SeongJae Park, Brendan Higgins, David Gow, Kefeng Wang,
Andrew Morton
damon_test_aggregate() is assuming all dynamic memory allocation in it
will succeed. Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail. In
the case, inappropriate memory access can happen. Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.
Link: https://lkml.kernel.org/r/20251101182021.74868-5-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
(cherry picked from commit f79f2fc44ebd0ed655239046be3e80e8804b5545)
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/core-test.h | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h
index 7008c3735e99..e60d47b344b0 100644
--- a/mm/damon/core-test.h
+++ b/mm/damon/core-test.h
@@ -86,12 +86,22 @@ static void damon_test_aggregate(struct kunit *test)
struct damon_region *r;
int it, ir;
- damon_set_targets(ctx, target_ids, 3);
+ if (!ctx)
+ kunit_skip(test, "ctx alloc fail");
+
+ if (damon_set_targets(ctx, target_ids, 3)) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "target alloc fail");
+ }
it = 0;
damon_for_each_target(t, ctx) {
for (ir = 0; ir < 3; ir++) {
r = damon_new_region(saddr[it][ir], eaddr[it][ir]);
+ if (!r) {
+ damon_destroy_ctx(ctx);
+ kunit_skip(test, "region alloc fail");
+ }
r->nr_accesses = accesses[it][ir];
damon_add_region(r, t);
}
--
2.47.3
^ permalink raw reply related [flat|nested] only message in thread