Re: [PATCH 12/12] mm/damon/core: add trace point for damos stat per apply interval

Steven Rostedt
2025-12-18T17:28:04Z

On Wed, 17 Dec 2025 18:29:15 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> > > Nit, but it's been stated that strings should not be broken up because of
> > > the column limit.
>
> screw the rules

Heh.

>
> > --- a/include/trace/events/damon.h
> > +++ b/include/trace/events/damon.h
> > @@ -40,9 +40,7 @@ TRACE_EVENT(damos_stat_after_apply_interval,
> > __entry->nr_snapshots = stat->nr_snapshots;
> > ),
> >
> > - TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu "
> > - "nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu "
> > - "qt_exceeds=%lu nr_snapshots=%lu",
> > + TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu qt_exceeds=%lu nr_snapshots=%lu",
> > __entry->context_idx, __entry->scheme_idx,
> > __entry->nr_tried, __entry->sz_tried,
> > __entry->nr_applied, __entry->sz_applied,
>
> because that's just crazy. Let's use some judgment here!

Does it really matter? Actually, I prefer this way because it better shows
where the format ends and the parameters start. I care more about the
parameters than the format string, except to look for each "%*" value.

-- Steve