Re: [RFC PATCH v2 02/10] mm/damon/core: allow quota goals set zero effective size quota

SeongJae Park
2026-03-05T00:55:03Z

On Wed, 4 Mar 2026 06:51:39 -0800 SeongJae Park <sj@kernel.org> wrote:

> On Wed, 4 Mar 2026 13:18:16 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:
>
> >
> >
> > On 3/4/2026 7:41 AM, SeongJae Park wrote:
> >
> > I find the name of this function confusing. The function doesn't
> > actually set anything. Maybe better damos_quota_is_set()
> > > +/*
> > > + * damos_quota_set() - Return if the given quota is actually set.
> > > + * @quota: The quota to check.
> > > + *
> > > + * Returns true if the quota is set, false otherwise.
> > > + */
> > > +static bool damos_quota_set(struct damos_quota *quota)
> > > +{
> > > + return quota->esz || quota->sz || quota->ms ||
> > > + !damos_quota_goals_empty(quota);
> > > +}
> > > +
>
> Thank you for the nice suggestion, I agree your points and like the suggested
> name!
>
> Andrew, if you pick this patch to mm-new for more reviews, could you please add
> below attaching fixup together?

Never mind. This is an RFC, which is not aiming to be merged into mm-new.
I'll squash the fixup to next spin of this patch.

Thanks,
SJ …