Re: (sashiko review) [PATCH v4 1/2] mm/damon/lru_sort: validate min_region_size to be power of 2

SeongJae Park
2026-04-14T00:39:08Z

On Tue, 14 Apr 2026 02:48:45 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:

> On Sun, 12 Apr 2026 14:37:19 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> > Hi Liew,
> >
> > On Mon, 13 Apr 2026 03:04:55 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> >
> > [...]
> > > > Next Steps
> > > > ----------
> > > >
> > > > So, what to do? Please prioritize series B, if you still willing to do. It is
> > > > ok to keep doing series A, but only as the minor user experience improvement.
> > > > Clearly explain the whole context you are aware of. Don't Cc stable@ for
> > > > series A, as it is only an incomplete fix of it. The fix of the one trigger
> > > > point is just a side effect.
> > >
> > > Yes, I absolutely want to continue contributing to DAMON.
> > >
> > > I realize most of this confusion came from me misinterpreting your words
> > > or making assumptions without asking. So this time, I want to be
> > > explicit:
> > > 1. I will remove the Cc stable@
> >
> > Please also make the description of the patch clear.
>
> I've been thinking about what you meant by "make the desciption of the
> patch clear" for Series A.
>
> Here's my current understanding:
>
> "
> This patch only fixes the case where kdamond terminates because
> 'min_region_sz' is not power-of-2. Other causes of unexpected
> termination (e.g., memory allocation failures) are not fixed by this
> patch. [Seires B] will address the general problem.
> "
>
> Is this what you had in mind? Or is there something else you think I
> should add or change?

To my understanding, you will make series B merged before this one, right? If
that's the case, you may not need to add this description at all. Rather, you
may better to clarify this is only a minor user experience improvement.

>
> > I'd like to avoid delaying series B too long, though. The bug is not very
> > critical, but better to be fixed sooner than later. If you have no enough
> > capacity, please feel free to hand it over to me.
>
> Yes, I have enough capacity. My exams are not until a couple of weeks
> later, so I can focus on Series B now.
>
> If my schedule gets too busy later, I will let you know and hand it over
> as you suggested. Thank you for offering that.

Sounds good.

Thanks,
SJ …