Re: (sashiko review) [PATCH v4 1/2] mm/damon/lru_sort: validate min_region_size to be power of 2

SeongJae Park
2026-04-10T17:00:52Z

On Sat, 11 Apr 2026 00:46:10 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:

> On Fri, 10 Apr 2026 06:55:00 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> > On Fri, 10 Apr 2026 17:40:04 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> >
> > > Sashiko found some issues.
> >
> > Clarifying what is the following action for the sashiko finding would be
> > helpful. For example, if you say "Sashiko found some issues, so I will post a
> > new versiuon soon", and if I'm busy, I can save my time by saying "Ok, then I
> > will skip or delaying review of this version and wait for your next review".
>
> Okay, I will keep that in mind next time I foward a Sashiko's Review.
> Thank you for you suggestion.
>
> > [...]
> >
> > Agreed. This was unclear to me in previous disucssions, though. I still agree
> > it is out of the scope of this patch. But now I think we need to let users
> > force-restart. Adding this to my todo list.
>
> Just to make sure - is this the same issue that my recent RFC patch [1]
> aims to address? I want to make sure we're not duplicating efforts.

Hmm, this makes me confused about how we ended up working on this series, then.

>
> I'm still actively working on that patch, and I plan to send the next
> version next week. I've been holding off because I didn't want to send
> multiple patches in parallel.

Ok, seems I dropped a ball. I was working like AI bot that only works with
limited and nearly fresh context for each mail that on my inbox. I will work
on making another thing for tracking this kind of parallel works with good
context. But since I already dropped the ball for this, I'd like to make sure
we are on the same page. So I'd suggest below.

1. Let's hold this patch series. Andrew, please don't merge this for now until
this discussion is completed.
2. Please summarize your parallel works in progress with the context about how
you decided to do that in the way, with summaries of our previous
discussions.

Could you please do those, Liew?

>
> [1] https://lore.kernel.org/20260330164347.12772-1-aethernet65535@gmail.com

Thanks,
SJ …