Re: [PATCH 2/2] Docs/ABI/damon: mark schemes/<S>/filters/ deprecated

[SeongJae Park <sj@kernel.org>]

On Wed, 29 Apr 2026 19:38:54 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing `What:` entries for files under the deprecated `filters/` and newly added `ops_filters/` directories.
> --
> 
> commit d4b50ba450c215da3baec9d7d831c83147cf209c
> Author: SeongJae Park <sj@kernel.org>
> 
> Docs/ABI/damon: mark schemes/<S>/filters/ deprecated
> 
> This commit deprecates the filters/ directory in the DAMON sysfs interface
> and updates the ABI documentation to use the new core_filters/ path. It also
> adds documentation for the ops_filters/ and filters/ directories, noting
> they work the same as core_filters/.
> 
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > index 2424237ebb10..b61a34b9b185 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > @@ -377,15 +377,20 @@ Contact:	SeongJae Park <sj@kernel.org>
> >  Description:	Writing to and reading from this file sets and gets the low
> >  		watermark of the scheme in permil.
> >  
> > -What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/filters/nr_filters
> > -Date:		Dec 2022
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/core_filters
> > +Date:		Feb 2025
> > +Contact:	SeongJae Park <sj@kernel.org>
> > +Description:	Directory for DAMON core layer-handled DAMOS filters.
> > +
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/core_filters/nr_filters
> > +Date:		Feb 2025
> >  Contact:	SeongJae Park <sj@kernel.org>
> >  Description:	Writing a number 'N' to this file creates the number of
> >  		directories for setting filters of the scheme named '0' to
> > -		'N-1' under the filters/ directory.
> > +		'N-1' under the core_filters/ directory.
> 
> [ ... ]
> 
> >  What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/ops_filters
> >  Date:		Feb 2025
> >  Contact:	SeongJae Park <sj@kernel.org>
> >  Description:	Directory for DAMON operations set layer-handled DAMOS filters.
> >  		Files under this directory works same to those of
> > -		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/filters
> > +		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/core_filters
> >  		directory.
> >  
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/filters
> > +Date:		Dec 2022
> > +Contact:	SeongJae Park <sj@kernel.org>
> > +Description:	Directory for DAMOS filters.  Files under this directory works
> > +		same to those of
> > +		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/{core,ops}_filters
> > +		directory.  This is deprecated.  Use the core_filters and
> > +		ops_filters instead.
> 
> Will automated ABI parsing tools like scripts/get_abi.pl be able to find the
> documentation for the individual files under the ops_filters/ and deprecated
> filters/ directories?

Seems now the script is renamed to tools/docs/get_abi.py.  And I'm not very
faimilar with the script, but I confirmed at least 'get_abi.py validate' is not
complaining anything about DAMON.

And this part was anyway like this before this patch.

> 
> Since the What: lines earlier in the patch were renamed from filters/ to
> core_filters/, the old sysfs attributes and the new ops_filters/ attributes
> are no longer explicitly listed. These tools rely strictly on explicit What:
> entries and ignore textual cross-references.
> 
> Should multiple What: lines be stacked above the shared descriptions so that
> the core_filters/, ops_filters/, and filters/ attributes are all correctly
> parsed?

So I will revisit if some people start complaining.


Thanks,
SJ

[...]