DAMON development mailing list
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SeongJae Park <sj@kernel.org>,
	"Vineet Agarwal" <agarwal.vineet2006@gmail.com>,
	damon@lists.linux.dev
Subject: Re: [PATCH] mm/damon/sysfs-schemes: fix double increment of nr_regions
Date: Tue, 12 May 2026 22:12:59 -0700	[thread overview]
Message-ID: <20260513051300.216917-1-sj@kernel.org> (raw)
In-Reply-To: <20260513042154.73E09C2BCB7@smtp.kernel.org>

On Wed, 13 May 2026 04:21:54 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [High] Incomplete fix leaves nr_regions counter permanently leaking on the error path.
> - [High] List corruption and Double Free due to lockless list manipulation in kobject release.
> - [Medium] Region directory naming preserves an unintended 1-based indexing regression.

Findings are same to those raised for the previous revision of this patch.  My
opinion is also same.  None of these are the fault of this patch.  Only the
list corruption issue seems valid and I will work on it.

Read my previous reply [1] for details.

[1] https://lore.kernel.org/20260513011920.119183-1-sj@kernel.org


Thanks,
SJ

[...]

      reply	other threads:[~2026-05-13  5:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  4:11 [PATCH] mm/damon/sysfs-schemes: fix double increment of nr_regions Vineet Agarwal
2026-05-12  4:53 ` SeongJae Park
2026-05-13  4:21 ` sashiko-bot
2026-05-13  5:12   ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513051300.216917-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=agarwal.vineet2006@gmail.com \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox