From: SeongJae Park <sj@kernel.org>
To: niecheng <niecheng1@uniontech.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel@uniontech.com
Subject: Re: [PATCH] mm/damon/core: clarify next_intervals_tune_sis update path
Date: Thu, 14 May 2026 16:45:09 -0700 [thread overview]
Message-ID: <20260514234510.123948-1-sj@kernel.org> (raw)
In-Reply-To: <D3B0C1F5BB6ADCE4+20260514163751.3399513-1-niecheng1@uniontech.com>
Hello nicheng,
On Fri, 15 May 2026 00:37:51 +0800 niecheng <niecheng1@uniontech.com> wrote:
> damon_set_attrs() updates next_aggregation_sis and
> next_ops_update_sis for online attrs updates, but it does not update
> next_intervals_tune_sis there.
>
> This can look like a missing update when reading damon_set_attrs()
> alone, while next_intervals_tune_sis is actually updated in
> kdamond_fn().
>
> Add a short comment to make this explicit.
Thank you for making the code easier to read!
>
> Suggested-by: SeongJae Park <sj@kernel.org>
> Link: https://lore.kernel.org/linux-mm/20260514144102.120203-1-sj@kernel.org/
So this is a second version of the patch on the above link, right? From the
next time, please add the version on the subject prefix, e.g., [PATCH v2].
Also, from the next time,please post a new version of patches as new thread,
rather than a reply to the previous version, with the revision changelog with
the link to the previous version [1] on the commentary area.
> Signed-off-by: niecheng <niecheng1@uniontech.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
[1] https://docs.kernel.org/process/submitting-patches.html#commentary
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-05-14 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 7:48 [PATCH] mm/damon/core: recalculate intervals tuning deadline on attrs update niecheng
2026-05-14 14:41 ` SeongJae Park
2026-05-14 16:15 ` niecheng
2026-05-14 16:37 ` [PATCH] mm/damon/core: clarify next_intervals_tune_sis update path niecheng
2026-05-14 23:45 ` SeongJae Park [this message]
2026-05-15 1:17 ` niecheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514234510.123948-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=niecheng1@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox