Re: [RFC PATCH v3 28/28] Docs/admin-guide/mm/damon/usage: update for memcg damon filter

[SeongJae Park <sj@kernel.org>]

On Sat, 16 May 2026 19:09:31 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] Inconsistent sysfs UAPI naming for identical memcg filter concepts ('path' vs 'memcg_path').
> - [Low] Awkward and non-standard grammar in the documentation.
> --
> 
> commit eca4a8cfbb76f7f5c4df18fb3c84beeef902be91
> Author: SeongJae Park <sj@kernel.org>
> 
> Docs/admin-guide/mm/damon/usage: update for memcg damon filter
> 
> Update DAMON usage document for the newly added belonging memory cgroup
> attribute monitoring feature.
> 
> > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
> > index 7b6074a1666f3..b4584c0e4cd72 100644
> > --- a/Documentation/admin-guide/mm/damon/usage.rst
> > +++ b/Documentation/admin-guide/mm/damon/usage.rst
> 
> [ ... ]
> 
> > @@ -283,7 +283,9 @@ the data attribute for the probe.
> >  In the beginning, ``filters`` directory has only one file, ``nr_filters``.
> >  Writing a number (``N``) to the file creates the number of child directories
> >  named ``0`` to ``N-1``.  Each directory represents each filter and works in a
> > -way similar to that for :ref:`DAMOS filter <sysfs_filters>`.
> > +way similar to that for :ref:`DAMOS filter <sysfs_filters>`.  When the filter
> > +``type`` is ``memcg``, ``path`` file works the role of ``memcg_path`` for
>                                       ^^^^^^^^^^^^^^^^^^
> 
> This isn't a bug, but this phrasing is non-standard. Would it be clearer
> to use "acts as" or "serves the same role as"?

Good catch, I will update the next version to use "acts as".

> 
> Also, does exposing this as "path" instead of "memcg_path" create an
> inconsistent sysfs UAPI?
> 
> DAMOS memcg filters use "memcg_path" for the exact same concept. Could the
> underlying kernel implementation rename "path" to "memcg_path" before the
> interface is finalized to keep the naming consistent?

No, I'm here to avoid such thing.

> 
> > +:ref:`DAMOS filter <sysfs_filters>`.
> >  
> >  .. _sysfs_targets:
> >
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260516183712.81393-1-sj@kernel.org?part=28


Thanks,
SJ