Re: [RFC PATCH 13/14] selftests/damon/sysfs.sh: test addr_unit file existence

[SeongJae Park <sj@kernel.org>]

On Wed, 20 May 2026 07:08:17 -0700 SeongJae Park <sj@kernel.org> wrote:

> On Wed, 20 May 2026 06:41:56 +0000 sashiko-bot@kernel.org wrote:
> 
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Medium] The newly added test for the `addr_unit` sysfs file incorrectly passes 'exit' instead of 'exist' to `ensure_file()`, causing the test check to be silently skipped.
> > --
> > 
> > commit a9bc6162fe06c0405081aeb68c3f5e9a54287e20
> > Author: SeongJae Park <sj@kernel.org>
> > 
> > selftests/damon/sysfs.sh: test addr_unit file existence
> > 
> > This commit adds a test to verify the existence of the addr_unit sysfs
> > file in the DAMON selftests.
> > 
> > > diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh
> > > index b3418214ed358..1e10881afabb6 100755
> > > --- a/tools/testing/selftests/damon/sysfs.sh
> > > +++ b/tools/testing/selftests/damon/sysfs.sh
> > > @@ -365,6 +365,7 @@ test_context()
> > >  	ensure_dir "$context_dir" "exist"
> > >  	ensure_file "$context_dir/avail_operations" "exit" 400
> > >  	ensure_file "$context_dir/operations" "exist" 600
> > > +	ensure_file "$context_dir/addr_unit" "exit" 600
> > 
> > [Severity: Medium]
> > Is "exit" a typo for "exist" in this new test?
> > 
> > If ensure_file() expects "exist" or "not_exist" as its second argument,
> > passing "exit" might cause the function to return immediately without
> > performing any file existence or permission checks, which would silently
> > skip the intended test coverage.
> 
> Good catch.  The ensure_file() expects "not_exist" or anything else for the
> second argument, so this test is working as intended.

Sashiko is correct.  The test was doing nothing.

> But definitely "exit" is
> a typo.  I will fix this in the next revision.

Anyway will be fixed in the next revision.


Thnks,
SJ

[...]