From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC89384CED; Thu, 21 May 2026 03:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779335643; cv=none; b=uvUYvC+9sRYOzojTvU0gYLVgmb5TTbAqScXZhOTn0Hv+PdIS9YOU6tf/xzbEgDGPTVvzwbwkBBzokgOd2AdNnkgHDhBDxGZ6Neo8D4/HSZ1H3nCuGMT2AtpHhyKHKNVVi1SBO4j5k+EWx6yOuElr9ne6694Sd+fqfvTqfFeZqjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779335643; c=relaxed/simple; bh=U3R/VpB5fsj2Kzc8E2SVAl/KkIrkOZVOd6iQ6EUqjEk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gRwjGSfUR82m2wLKvXrRRKYb1Bta36SbZPMhfTxsG4g4pYSp13giMI84QUXLSGDOZOWuISlDLkzgasOxRkCh0te+vEwka3nsheqf2vNJwO30IpNPALLa/BTGY3eABnOpFhub0HORT/4QjmClcCdZQUTrGBA+DLrEEPR1ApCCGUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GS5+7yZj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GS5+7yZj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 781701F000E9; Thu, 21 May 2026 03:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779335641; bh=lFIspApNE5pg+37NC/h+0JPjyuQa8BCwW93puC6WNUA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GS5+7yZjHYzX7LCTWtc/L6DB9/sG5kpJFCaI7/n5532/xEpMUQ8vgusEhPmw7T2Ma gBPdS0RgSBPhffmGarsfwajErtI2+tb2ODKgAFSfcDtYQ4WMLPPr5uc3HCP/tZYZE1 6+3MGEsi7xrtaMlgdqYEkfRy7TyWmS4KE8osSF5a3BMXvVIbLyvZ7TmsDG2stvNLhP HmnR7JOFKL5lKIQV1VaoBM41k1OK1A94XvD8NktytC3BzXx4DLMKS5mQCbJ7gD3/6S brlslJnwCdkRf1omQA0OVgU1F72nIht+f6FCkgL7nPa+9vXyDL9EDwZmYEdITHqzZV 57NIIx8CleC9A== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1.1 05/14] mm/damon/core: hide damon_add_region() Date: Wed, 20 May 2026 20:53:39 -0700 Message-ID: <20260521035349.87565-6-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260521035349.87565-1-sj@kernel.org> References: <20260521035349.87565-1-sj@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_add_region() is being used by only DAMON core, but exposed to DAMON API callers. Exposing something that is not really being used by others will only increase the maintenance cost. Hide it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 1 - mm/damon/core.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 4014fd0d463cb..b9370c1779cba 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -1024,7 +1024,6 @@ static inline void damon_insert_region(struct damon_region *r, t->nr_regions++; } -void damon_add_region(struct damon_region *r, struct damon_target *t); void damon_destroy_region(struct damon_region *r, struct damon_target *t); int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges, unsigned int nr_ranges, unsigned long min_region_sz); diff --git a/mm/damon/core.c b/mm/damon/core.c index e8cf3632115e5..7d1de6ff54eba 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -250,7 +250,7 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end) return region; } -void damon_add_region(struct damon_region *r, struct damon_target *t) +static void damon_add_region(struct damon_region *r, struct damon_target *t) { list_add_tail(&r->list, &t->regions_list); t->nr_regions++; -- 2.47.3