From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D866223A566 for ; Sun, 31 May 2026 09:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780219112; cv=none; b=f4/n/3BwjAcNoDja0wJFRsMnwMDxjEAp4+rh2BARu7yzC3GGCT3CRHnTSiV7DSzpxBU3nvo7JQiuOPG9oy0VuJyDb2qC6/JpzFHfHgpBcEWB8cB16XtYXPVx4gtZVQ361DvWZcvO6WvkI9OfmB8iS/SE7q8CEcmopbnvqp/SImY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780219112; c=relaxed/simple; bh=VZcQSRfQiopEACrfJex1DgYI+aBZbUYPqBPUPF6aiZ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LGmAg6rtap7ENP57YX9LjNJ9Dq5ENYuAzYM/zGq09M48z/KYddzbh86eGZdy6MBXi2bts2AuvEnH7ytk0w/fNL9ECLuPAtOvXWk6TP83kRWgpwzhFuFaOr+dRx6Glhu8WfuzCZ0i1oJfaX06lmPPJCSusYXBvUDXuirAgr8GyxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=m/6br8Pg; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="m/6br8Pg" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780219108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6imuRvcJ2QoeCub05D2ebeR8TkoLAgpZgEl546Rm/CQ=; b=m/6br8Pgr0pSniSxeY58mcipn8VEfCt3UaNwBwtJEymYbqoFWlk6qwGw8qfuifnrCdeHpo 6VJMZjHCwuuE/0/WMTjdnzfp/9HuT+62jbfWOGUWa2GIoXldzjZHq9ctR6xLEc9/FmgEcT dqMzlsvuNJgGsMSsL00C3XinN4F/VGI= From: Kunwu Chan To: sj@kernel.org, shuah@kernel.org Cc: damon@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kunwu Chan , Wang Lian , Kunwu Chan Subject: [PATCH 2/5] selftests/damon: fix memcg filter path handling Date: Sun, 31 May 2026 17:17:21 +0800 Message-ID: <20260531091724.84381-2-kunwu.chan@linux.dev> In-Reply-To: <20260531091724.84381-1-kunwu.chan@linux.dev> References: <20260531085633.48626-1-kunwu.chan@linux.dev> <20260531091724.84381-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Kunwu Chan A trailing comma in the memcg_path assignment makes memcg_path a single-element tuple instead of a string. As a result, an invalid value is written to sysfs and memcg filter configuration fails. Remove the comma. Co-developed-by: Wang Lian Signed-off-by: Wang Lian Signed-off-by: Kunwu Chan --- tools/testing/selftests/damon/_damon_sysfs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py index 2f6f2699db25..006c92a76ebe 100644 --- a/tools/testing/selftests/damon/_damon_sysfs.py +++ b/tools/testing/selftests/damon/_damon_sysfs.py @@ -271,7 +271,7 @@ class DamosFilter: self.type_ = type_ self.matching = matching self.allow = allow - self.memcg_path = memcg_path, + self.memcg_path = memcg_path self.addr_start = addr_start self.addr_end = addr_end self.target_idx = target_idx -- 2.43.0