Re: [PATCH v3 3/7] mm: Use mutable list iterators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] An unused `folio2` pointer was mistakenly added to `struct rmap_walk_arg`.
--

commit 8a79df314e3109d54ebea51144ac490e11160cb4
Author: Kaitao Cheng <chengkaitao@kylinos.cn>

mm: Use mutable list iterators

This patch mechanically converts mm users of safe list iterators to new mutable 
helpers. It drops temporary cursor variables that are no longer explicitly 
needed by the calling loops.

> diff --git a/mm/migrate.c b/mm/migrate.c
> index d9b23909d716c..acc7925d1d1b8 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
[ ... ]
> @@ -336,7 +335,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw,
>  }
>  
>  struct rmap_walk_arg {
> -	struct folio *folio;
> +	struct folio *folio, *folio2;
>  	bool map_unused_to_zeropage;
>  };

[Severity: Low]
Is folio2 actually used anywhere in struct rmap_walk_arg? It looks like this 
was mistakenly added as a leftover artifact of a mechanical search-and-replace 
when cleaning up the local cursor variables in nearby functions.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260622040533.29824-1-kaitao.cheng@linux.dev?part=3