DAMON development mailing list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SeongJae Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH v1.2 01/11] Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP
Date: Thu, 25 Jun 2026 14:29:36 +0000	[thread overview]
Message-ID: <20260625142936.903F91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260625142357.103500-2-sj@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Malformed reStructuredText inline literal syntax introduced for `node_memcg_used_bp` which will cause a Sphinx build warning.
--

commit a9ffce1612fd4b4c8226cfb7a55a1781daa5364d
Author: SeongJae Park <sj@kernel.org>

Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP

This commit updates the DAMON design document to include the
node_eligible_mem_bp goal metric, which was introduced earlier but
omitted from the design documentation.

> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index 2da7ca0d3d17a..9dbace087a329 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -686,9 +686,11 @@ mechanism tries to make ``current_value`` of ``target_metric`` be same to

[ ... ]

> -``nid`` is optionally required for only ``node_mem_used_bp``,
> -``node_mem_free_bp``, ``node_memcg_used_bp`` and ``node_memcg_free_bp`` to
> +``nid`` is optionally required for ``node_mem_used_bp``, ``node_mem_free_bp``,
> +``node_memcg_used_bp`,` ``node_memcg_free_bp`` and ``node_eligible_mem_bp`` to

[Severity: Low]
Does this malformed reStructuredText inline literal syntax cause a Sphinx build
warning?

It appears the backticks around node_memcg_used_bp are unbalanced due to a
misplaced backtick before the comma.

>  point the specific NUMA node.
>  
>  ``path`` is optionally required for only ``node_memcg_used_bp`` and

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625142357.103500-1-sj@kernel.org?part=1

  reply	other threads:[~2026-06-25 14:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25 14:23 [RFC PATCH v1.2 00/11] mm/damon: update, optimize, and clean up doc, tests, and code SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 01/11] Docs/mm/damon/design: update for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP SeongJae Park
2026-06-25 14:29   ` sashiko-bot [this message]
2026-06-25 14:36     ` SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 02/11] Docs/ABI/damon: document probe files SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 03/11] mm/damon/tests/core-kunit: test damon_rand() SeongJae Park
2026-06-25 14:31   ` sashiko-bot
2026-06-25 14:37     ` SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 04/11] selftests/damon/sysfs.sh: test multiple probe dirs creation SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 05/11] selftests/damon/sysfs.sh: test {core,ops}_filters/ directories SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 06/11] selftests/damon/sysfs.sh: test dests dir SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 07/11] selftests/damon/sysfs.sh: test all files in quota goal dir SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 08/11] mm/damon/core: reduce range setup in damon_commit_target_regions() SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 09/11] mm/damon/sysfs: split probe setup function out SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 10/11] mm/damon/sysfs: split out filters setup function SeongJae Park
2026-06-25 14:23 ` [RFC PATCH v1.2 11/11] mm/damon/sysfs: fix typos in probe_{add,rm}_dirs: s/attr/probe/ SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260625142936.903F91F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox