From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9BA3B9610; Sun, 28 Jun 2026 22:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782684087; cv=none; b=KxsE5hqXBfPP6d/G/d5ShA5GBjmoJmUF9oGVEL1OFjFSV6kfVzvKM3U0zOwYErIPTTCXzQOnOEM92C75Os4JCi0VnqhHvhb+Zgz7p1DzBwu5HjRgob9aSDuvA9w5aFJRxNxYd1raU4wdI9BdzjC4+kz+xnotoOLH6qB+duR/vI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782684087; c=relaxed/simple; bh=qtIy7HcR8Pi+T77I1ARVRBS58NgUemh49beCvE7AJBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PD6/nx1zqgzAFFvzCmzReSgOdBYqhax65pkohuKYZnZ4c39WUDIRU6xgT8iJ+7ha8rq/ZZFbXtj45geJ1eK2ED5A4b/sgeyeFB4r87fCf9qQpcvCJZZ6O3MP0OQmyY/QVWH/bohfYMwnuh5Rd0Wgx8euQVRnCWqa/0HHPZCTb1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Do8CglHv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Do8CglHv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE29C1F000E9; Sun, 28 Jun 2026 22:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782684085; bh=b2RwMvGvcXDxhpeE3Fm2y1VL7VUt3RWHHkP0dXl44lw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Do8CglHvvd6hU5kWZSRwGWzN4Hz8HtwGTGz1/VwmuA1/bhV09vN2ju/H+Eq0CAWxa +EVWFfLdCkGb9nd2DQ0Q0RMHsp4xITyCG0iZ0fkugh5EeUdcm68io3mihgCdyig8XW Noj92cdiKk0FZvVErunjGBHmsdhAwovibuM4CdLVAuBBPSD45PP+cIlKhtxHhr4ymi lRi+19TfEdyvkj0Stp7HxfoLNSQ5+FXFsLqGth6fydPqlxG9nqXKTEH2HRor8dZHFb VLEnR10QeLiZeCQqnSSGD2CscOEg9MQBTpP2ex8vxCcspd4jeMmU8NF0tF4I/bVnfH alZMsleQGlk1A== From: SJ Park To: Andrew Morton Cc: SJ Park , "# 5 . 18 . x" , Jiapeng Chong , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 01/11] mm/damon/sysfs: kobject_del() target (normal), context and kdamond dirs Date: Sun, 28 Jun 2026 15:01:10 -0700 Message-ID: <20260628220121.97360-2-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260628220121.97360-1-sj@kernel.org> References: <20260628220121.97360-1-sj@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On CONFIG_DEBUG_KOBJECT_RELEASE enabled kernel, lack of kobject_del() could cause directories creation failures due to the name conflicts. Fix those issues for normal creation paths of target, context and kdamond directories, and error paths of context and kdamond directories by adding kobject_del() calls. Note that this fix for target directories is not complete since it has a similar issue in the damon_sysfs_targets_add_dirs() error path. Because the normal path issue and the error path issue are introduced by different commits, this commit is fixing only the normal path issue. A commit for the error path will be added next. Fixes: c951cd3b8901 ("mm/damon: implement a minimal stub for sysfs-based DAMON interface") Cc: # 5.18.x Signed-off-by: SJ Park --- mm/damon/sysfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index a9e187158067d..38f3b02481f0a 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -331,6 +331,7 @@ static void damon_sysfs_targets_rm_dirs(struct damon_sysfs_targets *targets) for (i = 0; i < targets->nr; i++) { damon_sysfs_target_rm_dirs(targets_arr[i]); + kobject_del(&targets_arr[i]->kobj); kobject_put(&targets_arr[i]->kobj); } targets->nr = 0; @@ -1640,6 +1641,7 @@ static void damon_sysfs_contexts_rm_dirs(struct damon_sysfs_contexts *contexts) for (i = 0; i < contexts->nr; i++) { damon_sysfs_context_rm_dirs(contexts_arr[i]); + kobject_del(&contexts_arr[i]->kobj); kobject_put(&contexts_arr[i]->kobj); } contexts->nr = 0; @@ -1678,13 +1680,15 @@ static int damon_sysfs_contexts_add_dirs(struct damon_sysfs_contexts *contexts, err = damon_sysfs_context_add_dirs(context); if (err) - goto out; + goto del_out; contexts_arr[i] = context; contexts->nr++; } return 0; +del_out: + kobject_del(&context->kobj); out: damon_sysfs_contexts_rm_dirs(contexts); kobject_put(&context->kobj); @@ -2499,6 +2503,7 @@ static void damon_sysfs_kdamonds_rm_dirs(struct damon_sysfs_kdamonds *kdamonds) for (i = 0; i < kdamonds->nr; i++) { damon_sysfs_kdamond_rm_dirs(kdamonds_arr[i]); + kobject_del(&kdamonds_arr[i]->kobj); kobject_put(&kdamonds_arr[i]->kobj); } kdamonds->nr = 0; @@ -2553,13 +2558,15 @@ static int damon_sysfs_kdamonds_add_dirs(struct damon_sysfs_kdamonds *kdamonds, err = damon_sysfs_kdamond_add_dirs(kdamond); if (err) - goto out; + goto del_out; kdamonds_arr[i] = kdamond; kdamonds->nr++; } return 0; +del_out: + kobject_del(&kdamond->kobj); out: damon_sysfs_kdamonds_rm_dirs(kdamonds); kobject_put(&kdamond->kobj); -- 2.47.3