DAMON development mailing list
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SJ Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: [PATCH v2] MAINTAINERS: s/SeongJae/SJ/
Date: Mon, 29 Jun 2026 20:54:11 -0700	[thread overview]
Message-ID: <20260630035411.146557-1-sj@kernel.org> (raw)
In-Reply-To: <20260630014230.B10B81F000E9@smtp.kernel.org>

On Tue, 30 Jun 2026 01:42:30 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Unjustified removal of third-party corporate copyright notices.
> --
> 
> commit 01dda7537f36dfeb49164318c8fee42788b1510a
> Author: SJ Park <sj@kernel.org>
> 
> MAINTAINERS: s/SeongJae/SJ/
> 
> This patch updates the author's preferred name across the DAMON subsystem,
> including sysfs documentation, source files, and MAINTAINERS. It also removes
> copyright notes from these files, stating that they can be confusing.
> 
> [ ... ]
> 
> > diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> > index 1cfb8c176b873..fcf7c7fadb5fe 100644
> > --- a/mm/damon/tests/core-kunit.h
> > +++ b/mm/damon/tests/core-kunit.h
> > @@ -1,10 +1,6 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> >  /*
> >   * Data Access Monitor Unit Tests
> > - *
> > - * Copyright 2019 Amazon.com, Inc. or its affiliates.  All rights reserved.
> 
> [Severity: Medium]
> Is it okay to remove third-party corporate copyright notices like this?
> 
> While the commit message mentions removing copyright notes because they can
> be confusing, removing another entity's copyright (Amazon.com, Inc.)
> without explicit sign-off or authorization might violate standard kernel
> legal practices and risk copyright disputes.
> 
> Should these specific notices be retained unless there is explicit
> authorization from the copyright holder?

I'll reconsider if a human raises a concern.

> 
> > - *
> > - * Author: SeongJae Park <sj@kernel.org>
> >   */
> >  
> >  #ifdef CONFIG_DAMON_KUNIT_TEST
> 
> [ ... ]
> 
> > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h
> > index 563fbc7e3f448..61f844336ffb5 100644
> > --- a/mm/damon/tests/vaddr-kunit.h
> > +++ b/mm/damon/tests/vaddr-kunit.h
> > @@ -1,10 +1,6 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> >  /*
> >   * Data Access Monitor Unit Tests
> > - *
> > - * Copyright 2019 Amazon.com, Inc. or its affiliates.  All rights reserved.
> 
> [Severity: Medium]
> Does the same third-party copyright removal concern apply to this file
> as well?

Ditto.


Thanks,
SJ

[...]

  reply	other threads:[~2026-06-30  3:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  1:38 [PATCH v2] MAINTAINERS: s/SeongJae/SJ/ SJ Park
2026-06-30  1:42 ` sashiko-bot
2026-06-30  3:54   ` SJ Park [this message]
2026-06-30  5:18 ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630035411.146557-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox