DAMON development mailing list
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SJ Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target()
Date: Mon, 29 Jun 2026 21:07:58 -0700	[thread overview]
Message-ID: <20260630040812.149729-6-sj@kernel.org> (raw)
In-Reply-To: <20260630040812.149729-1-sj@kernel.org>

damon_nr_accesses_mvsum() returns a value same to nr_accesses_bp.  Also
the function is more simple and therefore more tolerant to errors.
Execution of the function would be more expensive than the simple read
of the field, but because the function is quite simple, the overhead
should be negligible.  Use it in __damos_valid_target() instead of the
nr_accesses_bp.

Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/core.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 70cbc382bec04..612762490e866 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2132,10 +2132,11 @@ static noinline_for_stack void kdamond_tune_intervals(struct damon_ctx *c)
 	damon_set_attrs(c, &new_attrs);
 }
 
-static bool __damos_valid_target(struct damon_region *r, struct damos *s)
+static bool __damos_valid_target(struct damon_region *r, struct damos *s,
+		struct damon_ctx *c)
 {
 	unsigned long sz;
-	unsigned int nr_accesses = r->nr_accesses_bp / 10000;
+	unsigned int nr_accesses = damon_nr_accesses_mvsum(r, c);
 
 	sz = damon_sz_region(r);
 	return s->pattern.min_sz_region <= sz &&
@@ -2161,7 +2162,7 @@ static bool damos_quota_is_set(struct damos_quota *quota)
 static bool damos_valid_target(struct damon_ctx *c, struct damon_region *r,
 		struct damos *s)
 {
-	bool ret = __damos_valid_target(r, s);
+	bool ret = __damos_valid_target(r, s, c);
 
 	if (!ret || !damos_quota_is_set(&s->quota) || !c->ops.get_scheme_score)
 		return ret;
@@ -2747,7 +2748,7 @@ static phys_addr_t damos_calc_eligible_bytes(struct damon_ctx *c,
 		damon_for_each_region(r, t) {
 			phys_addr_t addr, end_addr;
 
-			if (!__damos_valid_target(r, s))
+			if (!__damos_valid_target(r, s, c))
 				continue;
 
 			/* Convert from core address units to physical bytes */
@@ -3036,7 +3037,7 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s)
 			(DAMOS_MAX_SCORE + 1));
 	damon_for_each_target(t, c) {
 		damon_for_each_region(r, t) {
-			if (!__damos_valid_target(r, s))
+			if (!__damos_valid_target(r, s, c))
 				continue;
 			if (damos_core_filter_out(c, t, r, s))
 				continue;
-- 
2.47.3

  parent reply	other threads:[~2026-06-30  4:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  4:07 [PATCH 00/18] mm/damon: optimize out nr_accesses_bp SJ Park
2026-06-30  4:07 ` [PATCH 01/18] mm/damon/core: introduce damon_nr_accesses_mvsum() SJ Park
2026-06-30  4:19   ` sashiko-bot
2026-06-30  4:28     ` SJ Park
2026-06-30  4:07 ` [PATCH 02/18] mm/damon/tests/core-kunit: test damon_mvsum() SJ Park
2026-06-30  4:07 ` [PATCH 03/18] mm/damon/core: always update ->last_nr_accesses for intervals change SJ Park
2026-06-30  4:21   ` sashiko-bot
2026-06-30  4:30     ` SJ Park
2026-06-30  4:07 ` [PATCH 04/18] mm/damon/core: handle unreset nr_accesses in damon_nr_accesses_mvsum() SJ Park
2026-06-30  4:23   ` sashiko-bot
2026-06-30  4:33     ` SJ Park
2026-06-30  4:07 ` SJ Park [this message]
2026-06-30  4:25   ` [PATCH 05/18] mm/damon/core: use damon_nr_accesses_mvsum() in __damos_valid_target() sashiko-bot
2026-06-30  4:34     ` SJ Park
2026-06-30  4:07 ` [PATCH 06/18] mm/damon/core: use damon_nr_accesses_mvsum() for damos region tracing SJ Park
2026-06-30  4:08 ` [PATCH 07/18] mm/damon/sysfs-schemes: use damon_nr_accesses_mvsum() for damo regions SJ Park
2026-06-30  4:08 ` [PATCH 08/18] mm/damon/core: remove damon_warn_fix_nr_accesses_corruption() SJ Park
2026-06-30  4:08 ` [PATCH 09/18] mm/damon/core: remove damon_verify_reset_aggregated() SJ Park
2026-06-30  4:08 ` [PATCH 10/18] mm/damon/core: remove damon_verify_merge_regions_of() SJ Park
2026-06-30  4:08 ` [PATCH 11/18] mm/damon/tests/core-kunit: remove nr_accesses_bp setup and tests SJ Park
2026-06-30  4:08 ` [PATCH 12/18] selftests/damon/drgn_dump_damon_status: do not dump nr_accesses_bp SJ Park
2026-06-30  4:08 ` [PATCH 13/18] mm/damon/core: remove nr_accesses_bp setups and updates SJ Park
2026-06-30  4:08 ` [PATCH 14/18] mm/damon/core: remove attrs param from damon_update_region_access_rate() SJ Park
2026-06-30  4:19   ` sashiko-bot
2026-06-30  4:39     ` SJ Park
2026-06-30  4:48   ` SJ Park
2026-06-30  4:08 ` [PATCH 15/18] mm/damon/paddr: remove attrs param from __damon_pa_check_access() SJ Park
2026-06-30  4:08 ` [PATCH 16/18] mm/damon/vaddr: remove attrs param from __damon_va_check_access() SJ Park
2026-06-30  4:22   ` sashiko-bot
2026-06-30  4:45     ` SJ Park
2026-06-30  4:08 ` [PATCH 17/18] mm/damon/core: remove damon_moving_sum() and its unit test SJ Park
2026-06-30  4:08 ` [PATCH 18/18] mm/damon/core: remove damon_region->nr_accesses_bp SJ Park
2026-06-30  4:52 ` [PATCH 00/18] mm/damon: optimize out nr_accesses_bp SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630040812.149729-6-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox