From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641BA312825; Thu, 9 Jul 2026 14:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783605966; cv=none; b=PvERBASL6coqT2q9oclFF1iQSoxg36FAaEfpk1NQYBfQ9rbJjq5hReTsWIDb0AaD5PoLEnAfZd23HxD12Ga3PgWa8G9ACwzzpCWfrq/bNGirKM2zXMpBUFBpcsIg1Ml0Wgq7Xi/oqCJfsXPomld/aoXp/Yj2ngas/f/cMcudWfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783605966; c=relaxed/simple; bh=uAhzwsgrP8sxyAvNnPp5Ps2zkOO25kojkT0+us1QKJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PsNYo0MGU74C+FwdK7yTiiuL4Z/Wx8Ff+xZwVjTa1DutJrTXTOB+7BAe4YJFeyLO0ra9Uwa3khLIYlFLThHCiG3pgoHEl48nV1kIrau3GZ7LGHYJ8HcC8LOxk1NcZi+00KC0yfhx675k5w8c5A3/aRzZH3KPBBWMvlvzRe7e3SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wf8IEfuR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wf8IEfuR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 245371F00A3F; Thu, 9 Jul 2026 14:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783605965; bh=EAUgZZ3SWrIGgoijnllQjqFZihl0bkx/8MfT/CIerVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Wf8IEfuRhf2ecTkelQp+n69tNYlsE6nuD8zt/Sr6MTHtE3waC0OwlYp4vY9wkeaB+ DxI9LI/915IRsqV/LB6AI43V9aRGkRFO3KVJ7gKn3jdWVBDU+DX7GYKfMsIz8DYI5w bDhyNF89KjWPaUNQbVBDy4+9V3xO9VPwfXFvPSVUk/Lxw0KIKYxh/lo6p0wUzYHj2w ZiweLpHhIofQ20dqaeo6crq00ij/Qh8kJ4CzyxbtVDkPnFqrCvPl6Du5YBFoIL/fGt pvLss5te/FMIxKh6u/Cinqrdvp4Gm8LNFVRKEJiqVd1FZSLpAIuj1/mVYaB250U4z2 Ppn5LxE2VYKsA== From: SJ Park To: Cc: SJ Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1.2 04/19] mm/damon/core: ask apply_probe() to return max probe hits weighted sum Date: Thu, 9 Jul 2026 07:05:42 -0700 Message-ID: <20260709140600.90950-5-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260709140600.90950-1-sj@kernel.org> References: <20260709140600.90950-1-sj@kernel.org> Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit check_accesses() DAMON ops callback returns the maximum nr_accesses of regions. DAMON core uses it to calculate a reasonable region merge threshold. The core will need to adjust regions for not nr_accesses but probe hits weighted sum in future. For that, the core needs to know the maximum weighted sum of the regions. Update the protocol for the task. Signed-off-by: SJ Park --- include/linux/damon.h | 7 +++++-- mm/damon/core.c | 2 +- mm/damon/paddr.c | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 3c2a4d673bf62..4e1845ce83870 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -648,7 +648,9 @@ enum damon_ops_id { * of its update. The value will be used for regions adjustment threshold. * @apply_probes should apply the data attribute probes to each region and * accordingly update the probe hits counter of the region. It should also - * &set sampling_addr of each region if ``set_samples`` is true. + * &set sampling_addr of each region if ``set_samples`` is true. It should + * also return maximum probe hits weighted sum of regions if + * ``return_max_wsum`` is true. * @get_scheme_score should return the priority score of a region for a scheme * as an integer in [0, &DAMOS_MAX_SCORE]. * @apply_scheme is called from @kdamond when a region for user provided @@ -666,7 +668,8 @@ struct damon_operations { void (*update)(struct damon_ctx *context); void (*prepare_access_checks)(struct damon_ctx *context); unsigned int (*check_accesses)(struct damon_ctx *context); - void (*apply_probes)(struct damon_ctx *context, bool set_samples); + unsigned int (*apply_probes)(struct damon_ctx *context, + bool set_samples, bool return_max_wsum); int (*get_scheme_score)(struct damon_ctx *context, struct damon_region *r, struct damos *scheme); unsigned long (*apply_scheme)(struct damon_ctx *context, diff --git a/mm/damon/core.c b/mm/damon/core.c index 9fbea6204520b..9f6cdd810bd8a 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -3692,7 +3692,7 @@ static int kdamond_fn(void *data) if (ctx->ops.check_accesses) max_nr_accesses = ctx->ops.check_accesses(ctx); if (ctx->ops.apply_probes) - ctx->ops.apply_probes(ctx, false); + ctx->ops.apply_probes(ctx, false, false); if (time_after_eq(ctx->passed_sample_intervals, next_aggregation_sis)) { diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index ff4fcca949660..3eba3564a31fc 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -166,7 +166,8 @@ static bool damon_pa_filter_pass(phys_addr_t pa, struct folio *folio, return pass; } -static void damon_pa_apply_probes(struct damon_ctx *ctx, bool set_samples) +static unsigned int damon_pa_apply_probes(struct damon_ctx *ctx, + bool set_samples, bool return_max_wsum) { struct damon_target *t; struct damon_region *r; @@ -194,6 +195,7 @@ static void damon_pa_apply_probes(struct damon_ctx *ctx, bool set_samples) folio_put(folio); } } + return 0; } /* -- 2.47.3