From: sashiko-bot@kernel.org
To: "Doehyun Baek" <doehyunbaek@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v7 2/7] docs/zh_CN: add DAMON_STAT usage translation
Date: Wed, 12 Aug 2026 07:07:03 +0000 [thread overview]
Message-ID: <20260812070704.33AC71F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812065914.3071433-3-doehyunbaek@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The newly added translation file `stat.rst` is not included in any `toctree`, which will result in a Sphinx build warning and make it undiscoverable.
- [Low] The patch adds a translation for `DAMON_STAT` (`stat.rst`) and its kernel feature configuration (`CONFIG_DAMON_STAT`), but neither the original English documentation (`Documentation/admin-guide/mm/damon/stat.rst`) nor the kernel feature exist in the source tree.
--
--- Patch [2]: [PATCH v7 2/7] docs/zh_CN: add DAMON_STAT usage translation ---
commit a87967677ba5385276c4f77cf4f3e6a1d32e5754
Author: Doehyun Baek <doehyunbaek@gmail.com>
docs/zh_CN: add DAMON_STAT usage translation
This commit adds a Chinese translation for the DAMON_STAT documentation
and updates it through commit c9380cdd949d.
> diff --git a/Documentation/translations/zh_CN/admin-guide/mm/damon/stat.rst b/Documentation/translations/zh_CN/admin-guide/mm/damon/stat.rst
> new file mode 100644
> index 0000000000000..129748a5ea1f0
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/admin-guide/mm/damon/stat.rst
> @@ -0,0 +1,94 @@
> +.. SPDX-License-Identifier: GPL-2.0
[Severity: Low]
Since this newly added translation file does not appear to be included in
the toctree in Documentation/translations/zh_CN/admin-guide/mm/damon/index.rst,
will this cause a Sphinx build warning and make the page undiscoverable in
the generated HTML documentation?
> +.. include:: ../../../disclaimer-zh_CN.rst
> +
> +:Original: Documentation/admin-guide/mm/damon/stat.rst
[Severity: Low]
Is the original English documentation present in the source tree? It looks
like Documentation/admin-guide/mm/damon/stat.rst does not exist.
[ ... ]
> +接口:模块参数
> +==============
> +
> +要使用这个功能,首先应确保你的系统运行在构建时启用了
> +``CONFIG_DAMON_STAT=y`` 的内核上。通过将
[Severity: Low]
Does the CONFIG_DAMON_STAT configuration option exist in the kernel? It
seems this translation documents a feature that is absent from the current
kernel source tree.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812065914.3071433-1-doehyunbaek@gmail.com?part=2
next prev parent reply other threads:[~2026-08-12 7:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:59 [PATCH v7 0/7] docs/zh_CN: update DAMON documentation translation Doehyun Baek
2026-08-12 6:59 ` [PATCH v7 1/7] docs/zh_CN: update DAMON design translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 2/7] docs/zh_CN: add DAMON_STAT usage translation Doehyun Baek
2026-08-12 7:07 ` sashiko-bot [this message]
2026-08-12 6:59 ` [PATCH v7 3/7] docs/zh_CN: update DAMON index translation Doehyun Baek
2026-08-12 7:05 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 4/7] docs/zh_CN: update DAMON start translation Doehyun Baek
2026-08-12 7:07 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 5/7] docs/zh_CN: update DAMON usage translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 6/7] docs/zh_CN: update DAMON reclaim translation Doehyun Baek
2026-08-12 7:02 ` sashiko-bot
2026-08-12 6:59 ` [PATCH v7 7/7] docs/zh_CN: update DAMON LRU sort translation Doehyun Baek
2026-08-12 7:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812070704.33AC71F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=doehyunbaek@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox