From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 6.12.y] mm/damon/ops-common: putback folios on invalid migrate nid
Date: Tue, 18 Aug 2026 06:31:17 +0000 [thread overview]
Message-ID: <20260818063118.627141F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818062518.91960-1-sj@kernel.org>
> From: liyouhong <liyouhong@kylinos.cn>
>
> damon_pa_migrate() and damos_va_migrate() isolate folios into a local list
> and then call damon_migrate_pages(). When target_nid is invalid
> (including the scheme default NUMA_NO_NODE / -1), damon_migrate_pages()
> returns early without putting the folios back to the LRU.
>
> Callers then discard the list head while those folios remain isolated with
> an extra reference taken by folio_isolate_lru(). The pages stay off the
> LRU for as long as the mapping exists (anon active+inactive counts drop
> while RSS does not), and the leftover references can pin the pages after
> the mapping is gone.
>
> Put the folios back on the invalid-nid path so ignored migration requests
> still return them to the LRU.
>
> Link: https://lore.kernel.org/20260726014815.1280757-1-dayou5941@163.com
> Fixes: 7e6c3130690a ("mm/damon/ops-common: ignore migration request to invalid nodes")
> Assisted-by: Cursor:grok-4.5
> Reviewed-by: SJ Park <sj@kernel.org>
> Signed-off-by: liyouhong <liyouhong@kylinos.cn>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> (cherry picked from commit 5deb65c34e682e7c5f5df417a70e223e8fcc5f5a)
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818062518.91960-1-sj@kernel.org?part=1
prev parent reply other threads:[~2026-08-18 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2026081721-strainer-detract-6eed@gregkh>
2026-08-18 6:25 ` [PATCH 6.12.y] mm/damon/ops-common: putback folios on invalid migrate nid SJ Park
2026-08-18 6:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818063118.627141F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox