From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [RFC PATCH v1.2 2/8] mm/damon/paddr: respect folio end for DAMOS_STAT
Date: Mon, 31 Aug 2026 17:54:17 +0000 [thread overview]
Message-ID: <20260831175418.64EDE1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260831140254.72004-3-sj@kernel.org>
> The function for applying DAMOS_STAT in DAMON physical address space
> operation set (paddr), namely damon_pa_stat(), applies DAMOS filters to
> folios of the given region. For that, it gets folios of addresses in
> the region. It starts from the region start address and advances the
> address by the size of the folio of the address until it goes out of the
> region. If the start address is in the middle of a large folio, and if
> the next folios are small, some of the next folios could be skipped. Fix
> the issue by advancing the address to exactly the start address of the
> next folio.
>
> The user impact is that the DAMOS_STAT-based page level monitoring
> results become inaccurate. Since the page level monitoring is supposed
> to provide relatively high precision, this is definitely a problem. It
> is arguably not critical since it is only monitoring quality
> degradation.
>
> Fixes: bdbe1d7bc325 ("mm/damon/paddr: increment pa_stat damon address range by folio size")
> Cc: <stable@vger.kernel.org> # 6.14.x
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831140254.72004-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-08-31 17:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 14:02 [RFC PATCH v1.2 0/8] mm/damon: fix DAMOS bugs in core, paddr and vaddr SJ Park
2026-08-31 14:02 ` [RFC PATCH v1.2 1/8] mm/damon/core: skip applying scheme if region split for quota fails SJ Park
2026-08-31 17:45 ` sashiko-bot
2026-08-31 14:02 ` [RFC PATCH v1.2 2/8] mm/damon/paddr: respect folio end for DAMOS_STAT SJ Park
2026-08-31 17:54 ` sashiko-bot [this message]
2026-08-31 14:02 ` [RFC PATCH v1.2 3/8] mm/damon/paddr: respect folio end for DAMOS actions except STAT SJ Park
2026-08-31 18:06 ` sashiko-bot
2026-08-31 14:02 ` [RFC PATCH v1.2 4/8] mm/damon/vaddr: respect folio end for DAMOS_STAT SJ Park
2026-08-31 18:14 ` sashiko-bot
2026-08-31 14:02 ` [RFC PATCH v1.2 5/8] mm/damon/vaddr: respect folio end for DAMOS_MIGRATE_{HOT,COLD} SJ Park
2026-08-31 18:23 ` sashiko-bot
2026-08-31 14:02 ` [RFC PATCH v1.2 6/8] mm/damon/core: handle extreme memory state in damon_get_node_mem_bp() SJ Park
2026-08-31 18:29 ` sashiko-bot
2026-08-31 14:02 ` [RFC PATCH v1.2 7/8] mm/damon/core: handle extreme memory state in get_node_memcg_used_bp() SJ Park
2026-08-31 18:41 ` sashiko-bot
2026-09-01 0:36 ` SJ Park
2026-08-31 14:02 ` [RFC PATCH v1.2 8/8] mm/damon/core: handle extreme memory state in get_in_active_mem_bp() SJ Park
2026-08-31 18:49 ` sashiko-bot
2026-09-01 0:37 ` SJ Park
2026-09-01 0:50 ` [RFC PATCH v1.2 0/8] mm/damon: fix DAMOS bugs in core, paddr and vaddr SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831175418.64EDE1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox