From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v2 2/2] mm/damon/core-kunit: test damon_valid_probe_params()
Date: Mon, 31 Aug 2026 18:15:30 +0000 [thread overview]
Message-ID: <20260831181530.895641F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831150650.84829-3-sj@kernel.org>
> From: Jason Angelov <jasonangelov@ucla.edu>
>
> damon_valid_probe_params() makes damon_commit_ctx() reject probe
> configurations that could overflow a probe_hits counter, a single
> (weight * probe_hits) product, or the sum of those products.
>
> Add a kunit test covering each rejection at its boundary:
>
> - samples per aggregation interval: U8_MAX is allowed, one more could
> overflow a probe_hits counter
> - single weight: the largest whose product fits in unsigned int is
> allowed, one larger is rejected
> - multiple probes: each product fits, but their sum overflows
> - no weight set: the validation is skipped
>
> Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>
> Reviewed-by: SJ Park <sj@kernel.org>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831150650.84829-1-sj@kernel.org?part=2
prev parent reply other threads:[~2026-08-31 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 15:06 [PATCH v2 0/2] mm/damon: add kunit tests for probe_hits handling and probe params validation SJ Park
2026-08-31 15:06 ` [PATCH v2 1/2] mm/damon/core-kunit: test probe_hits handling at region split and merge SJ Park
2026-08-31 18:10 ` sashiko-bot
2026-08-31 15:06 ` [PATCH v2 2/2] mm/damon/core-kunit: test damon_valid_probe_params() SJ Park
2026-08-31 18:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831181530.895641F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox