Re: [PATCH] mm/damon/tests/core-kunit: add test for unconditionally skipping the last region

[Liew Rui Yan <aethernet65535@gmail.com>]

On Mon, 31 Aug 2026 17:25:14 -0700 SJ Park <sj@kernel.org> wrote:

> On Mon, 31 Aug 2026 20:28:15 +0800 Liew Rui Yan <aethernet65535@gmail.com> wrote:
> 
> > On Mon, 31 Aug 2026 11:50:14 +0000 sashiko-bot@kernel.org wrote:
> [...] 
> > > [Severity: Medium]
> > > Does this patch omit the fix for the core logic?
> > > 
> > > Without an accompanying fix for damos_skip_charged_region() in
> > > mm/damon/core.c, won't this new test unconditionally fail and break CI?
> > > 
> > > Because the underlying bug is not fixed in this patch, the old logic still
> > > triggers and returns true when it processes the last region:
> > > 
> > > mm/damon/core.c:damos_skip_charged_region() {
> > > 	...
> > > 	if (quota->charge_target_from) {
> > > 		if (t != quota->charge_target_from)
> > > 			return true;
> > > 		if (r == damon_last_region(t)) {
> > > 			quota->charge_target_from = NULL;
> > > 			quota->charge_addr_from = 0;
> > > 			return true;
> > > 		}
> > > 	...
> > > }
> > 
> > This test is add for [1].  Therefore, this patch can only be merged
> > after [1] is merged.
> 
> Makes sense.
> 
> > 
> > [1] https://lore.kernel.org/damon/20260830063159.6347-1-aethernet65535@gmail.com
> 
> I wonder if you are open to repost this after the dependent patch is merged
> into mm-new.  It would be definitely inconvenient for you, but that would help
> us getting AI review help.  What do you think?

Okay!  That will not be inconvenient :>

Best regards,
Rui Yan