DAMON development mailing list
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SJ Park <sj@kernel.org>,
	stable@vger.kernel.org, damon@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 1/8] mm/damon/core: skip applying scheme if region split for quota fails
Date: Tue,  1 Sep 2026 06:18:42 -0700	[thread overview]
Message-ID: <20260901131850.98037-2-sj@kernel.org> (raw)
In-Reply-To: <20260901131850.98037-1-sj@kernel.org>

damos_apply_scheme() splits a region and apply the action to the
subregion if it is needed for not violating the quota.  The split
operation (damon_split_region_at()) could fail for allocation failure.
In the case, the quota could be violated.  From the user's perspective,
DAMOS becomes more aggressive than expected under the extreme situation.
Handle the failure.

The user impact is not critical.  The failure of damon_split_region_at()
is unlikely since it is arguably too small to fail.  Also DAMOS being
aggressive is limited to the single region.  Users can set
min_nr_regions to set the maximum size of each region.  If it is
reasonably set, the transient overhead shouldn't be critical.

The issue was discovered [1] by Sashiko.

[1] https://lore.kernel.org/20260718171523.87547-1-sj@kernel.org

Fixes: 2b8a248d5873 ("mm/damon/schemes: implement size quota for schemes application speed control")
Cc: <stable@vger.kernel.org> # 5.16.x
Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 3f89cfdf5f022..a6fdb3068262d 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2604,7 +2604,8 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,
 					c->min_region_sz);
 			if (!sz)
 				goto update_stat;
-			damon_split_region_at(t, r, sz);
+			if (damon_split_region_at(t, r, sz))
+				goto update_stat;
 		}
 		if (damos_core_filter_out(c, t, r, s))
 			return;
-- 
2.47.3

  reply	other threads:[~2026-09-01 13:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 13:18 [PATCH 0/8] mm/damon: fix DAMOS bugs in core, paddr and vaddr SJ Park
2026-09-01 13:18 ` SJ Park [this message]
2026-09-01 13:28   ` [PATCH 1/8] mm/damon/core: skip applying scheme if region split for quota fails sashiko-bot
2026-09-01 13:18 ` [PATCH 2/8] mm/damon/paddr: respect folio end for DAMOS_STAT SJ Park
2026-09-01 13:27   ` sashiko-bot
2026-09-01 13:18 ` [PATCH 3/8] mm/damon/paddr: respect folio end for DAMOS actions except STAT SJ Park
2026-09-01 13:27   ` sashiko-bot
2026-09-01 13:18 ` [PATCH 4/8] mm/damon/vaddr: respect folio end for DAMOS_STAT SJ Park
2026-09-01 13:29   ` sashiko-bot
2026-09-01 13:18 ` [PATCH 5/8] mm/damon/vaddr: respect folio end for DAMOS_MIGRATE_{HOT,COLD} SJ Park
2026-09-01 13:26   ` sashiko-bot
2026-09-01 13:18 ` [PATCH 6/8] mm/damon/core: handle extreme memory state in damon_get_node_mem_bp() SJ Park
2026-09-01 13:35   ` sashiko-bot
2026-09-01 13:18 ` [PATCH 7/8] mm/damon/core: handle extreme memory state in get_node_memcg_used_bp() SJ Park
2026-09-01 13:41   ` sashiko-bot
2026-09-01 14:29     ` SJ Park
2026-09-01 13:18 ` [PATCH 8/8] mm/damon/core: handle extreme memory state in get_in_active_mem_bp() SJ Park
2026-09-01 13:36   ` sashiko-bot
2026-09-01 14:30     ` SJ Park
2026-09-01 14:30 ` [PATCH 0/8] mm/damon: fix DAMOS bugs in core, paddr and vaddr SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901131850.98037-2-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox