damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 2/7] mm/damon/paddr: respect folio end for DAMOS actions except STAT
Date: Tue, 01 Sep 2026 13:22:54 +0000	[thread overview]
Message-ID: <20260901132254.E035F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260901131326.97615-3-sj@kernel.org>

> A few functions for applying DAMOS actions including pageout,
> lru_[de]prio and migrate_{hot,cold} in DAMON physical address space
> operation set (paddr) collect folios of the given region by getting the
> folios of region-internal addresses.  Then, those functions apply the
> action to the collected folios at once.  The collection starts from the
> region start address and advances the address by the size of the folio
> of the address until it goes out of the region.  If the start address is
> in the middle of a large folio, and if the next folios are small, some
> of the next folios could be skipped.  Fix the issue by advancing the
> address to exactly the start address of the next folio.
> 
> The user impact is that DAMOS action is applied to less than expected
> amount of memory.  Given the best effort nature of DAMON, it is no big
> problem, but it is clearly a bug that is better to be fixed.
> 
> The issue was discovered [1] by Sashiko.
> 
> [1] https://lore.kernel.org/20260517234112.89245-1-sj@kernel.org
> 
> Fixes: 3a06696305e7 ("mm/damon/ops: have damon_get_folio return folio even for tail pages")
> Cc: <stable@vger.kernel.org> # 6.15.x
> Signed-off-by: SJ Park <sj@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901131326.97615-1-sj@kernel.org?part=2


  reply	other threads:[~2026-09-01 13:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 13:13 [PATCH 0/7] damos_apply_scheme() splits a region and apply the action to the SJ Park
2026-09-01 13:13 ` [PATCH 1/7] mm/damon/paddr: respect folio end for DAMOS_STAT SJ Park
2026-09-01 13:23   ` sashiko-bot
2026-09-01 13:13 ` [PATCH 2/7] mm/damon/paddr: respect folio end for DAMOS actions except STAT SJ Park
2026-09-01 13:22   ` sashiko-bot [this message]
2026-09-01 13:13 ` [PATCH 3/7] mm/damon/vaddr: respect folio end for DAMOS_STAT SJ Park
2026-09-01 13:33   ` sashiko-bot
2026-09-01 13:13 ` [PATCH 4/7] mm/damon/vaddr: respect folio end for DAMOS_MIGRATE_{HOT,COLD} SJ Park
2026-09-01 13:32   ` sashiko-bot
2026-09-01 13:13 ` [PATCH 5/7] mm/damon/core: handle extreme memory state in damon_get_node_mem_bp() SJ Park
2026-09-01 13:41   ` sashiko-bot
2026-09-01 13:13 ` [PATCH 6/7] mm/damon/core: handle extreme memory state in get_node_memcg_used_bp() SJ Park
2026-09-01 13:46   ` sashiko-bot
2026-09-01 13:13 ` [PATCH 7/7] mm/damon/core: handle extreme memory state in get_in_active_mem_bp() SJ Park
2026-09-01 13:56   ` sashiko-bot
2026-09-01 13:16 ` [PATCH 0/7] damos_apply_scheme() splits a region and apply the action to the SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901132254.E035F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).