From: sashiko-bot@kernel.org
To: "Nathan Gao" <zcgao@amazon.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v4] mm/damon/ops-common: use a page-aligned address in damon_ptep_mkold()
Date: Wed, 02 Sep 2026 03:24:47 +0000 [thread overview]
Message-ID: <20260902032447.AB99C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902031655.84721-1-zcgao@amazon.com>
> __damon_va_prepare_access_check() picks a random byte address within the
> region and stores it in r->sampling_addr. damon_va_mkold() passes it into
> a page table walk, which hands it to damon_ptep_mkold() as the address of
> the page to sample:
>
> damon_va_mkold(mm, r->sampling_addr)
> damon_va_walk_page_range(mm, addr, addr + 1)
> damon_mkold_pmd_entry()
> damon_ptep_mkold(pte, vma, addr)
> ptep_test_and_clear_young(vma, addr, pte)
> mmu_notifier_clear_young(mm, addr, addr + PAGE_SIZE)
>
> For arm64, before commit 6f0e1142173a ("arm64: mm: support batch
> clearing of the young flag for large folios"), the contpte helper walked
> exactly CONT_PTES entries from the aligned-down page table pointer and
> [ ... ]
> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: David Hildenbrand (Arm) <david@kernel.org>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Nathan Gao <zcgao@amazon.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902031655.84721-1-zcgao@amazon.com?part=1
next prev parent reply other threads:[~2026-09-02 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 3:16 [PATCH v4] mm/damon/ops-common: use a page-aligned address in damon_ptep_mkold() Nathan Gao
2026-09-02 3:24 ` sashiko-bot [this message]
2026-09-02 4:06 ` SJ Park
2026-09-02 5:27 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902032447.AB99C1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zcgao@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox